Package dimensions can round down to 0

Created on 6 December 2024, 17 days ago

Problem/Motivation

When using the all in one packer and the custom box (1mm x 1mm x 1mm) the resulting package dimensions are 0. This means no rates are returned.

This is a result of using round() when calculating package dimensions instead of ceil(). When evaluating package size for determining shipping cost carriers always round up to the next whole unit. The code should always round up to the next unit too.

Steps to reproduce

Create a FedEx shipping method with the All in one packer. Create a shipment in the admin area of an order. Select the custom box (1mm x 1mm x 1mm) package type. Calculate rates. No rates returned.

Proposed resolution

Change round() to ceil() in physicalLengthsToFedexDimensions()

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States rhovland Oregon

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024