getRequestedPackageLineItemsAllInOne() creates invalid packages

Open on Drupal.org →

Created on 5 December 2024, 17 days ago

Problem/Motivation

When creating a new shipment from the order admin screen the following error occurs:
Error: Call to a member function render() on null in Drupal\commerce_fedex\Plugin\Commerce\ShippingMethod\FedEx->getRequestedPackageLineItemsAllInOne()

This error exposes that the getRequestedPackageLineItemsAllInOne() function is designed incorrectly. It iterates over packages and then tries to insert a single line item with the shipment title as the description.

Steps to reproduce

Create a FedEx shipping method. Set the packer to "All in one". Create a new shipment on the order shipments admin screen.

Proposed resolution

Rewrite getRequestedPackageLineItemsAllInOne() so it iterates over line items in the shipment and adds each shipment item as a line item in the rate request like it does in getRequestedPackageLineItemsIndividual()

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States rhovland Oregon

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!25getRequestedPackageLineItemsAllInOne() creates invalid packages
Open
🇺🇸United States rhovland
updated 16 days ago

Comments & Activities

Issue created by @rhovland
Comment 17 days ago →
🇺🇸United States rhovland Oregon
Merge request !25Issue #3492075 by rhovland: Fix PACKAGE_ALL_IN_ONE WSOD when creating new shipment → (Open) created by rhovland
Pipeline finished with Failed
17 days ago
Total: 358s
#360650
Comment 17 days ago →
🇺🇸United States rhovland Oregon
Issue fixed. Uses null coalescing operator to set a package name if $shipment_title is null.

I moved $shipment_title = $shipment->getTitle() and $package_type = $shipment->getPackageType() outside of the foreach loop because the loop is for packages not shipments and those variables don't need to be reset for every package because they will never change.
Comment 17 days ago →
🇺🇸United States rhovland Oregon
I investigated the source of $shipment_title->render() and did not find an issue that it was added to solve. It seems to be vestige of an earlier module version and I can't find a reason why it would be needed.
First commit to issue fork.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024