Style installer with updated designs.

Account form may needs some work, but posting for initial review :)

No objections to the CSS code as I'm not a frontender, but I'm really uncomfortable with passing a user-specified email address and password around in cleartext in the URL, which is what this MR does. URLs are logged in various places, including places external to Drupal, and therefore they are not an appropriate place for superuser (remember, we're creating user 1 here) account credentials.

That's not your fault; the installer is a topsy-turvy environment where it's hard to find ways to persist data away from potentially prying eyes.

I think I need to block this issue on 📌 Allow to set administrator email on installation Active , which should implement the credential collection form and find a more secure way to store that data (probably the filesystem, to be honest) until the base system is installed.

Oh thank you! Those parts in the URL did seem fishy to me. I mostly built the form so I could make sure it was styled, so really appreciate having it done better

OK - just merged the blocker, so this is back to you, @rikki_iki. The things to know here:

The AccountForm is gone as a distinct class. Ultimately it made more sense (and was the most secure option, validated with @catch in Slack) to simply form_alter the existing install_configure_form to make it look and act the way we want.

The only thing that might be a little tricky here, I think, is the "step X of N" stuff. The reason it will be tricky is because there might be 3 or 4 steps depending on whether the database has been preconfigured (i.e., by DDEV). It's easy to detect that ($install_state['settings_verified'] will be TRUE if it is), but then we have to make sure we can render that consistently in the forms themselves. I have some ideas. In the meantime, you'll need to restore the "step X of Y" markup to the form-altered install_configure_form.

The flow is:

1. Choose recipes
2. Name the site
3. Set up the database (this might be skipped if preconfigured)
4. Create account

So if we need to hard-code it, we can just say there are 4 steps. The fact that step 3 is skipped over might not be of any concern to users.

I fixed the merge conflicts here and I think I managed to preserve all of @rikki_iki's work.

Therefore, assigning to @pameeela to do a bit of testing.

This looks good, happy to merge. I'll make a follow up for "Step X of 4" is a bit weird since we skip step 3 in many cases, but I don't want to remove it here, let's get it in. We need a follow up anyway for some minor fixes that @rikki_iki was going to work on, we can create a new issue for that.

I tested this too and I really like it. Looks glorious. Clean implementation. Shippety-shippin' it. Merged into 0.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.