- Issue created by @roromedia
- π¬π§United Kingdom MrDaleSmith
The token browser isn't part of this module, so isn't ours to do anything about. Other modules have been developed that mitigate this issue for larger sites so if you are having this issue you may wish to investigate them, or raise it as an issue with the Token module's team (although I suspect it has been raised before so search their issue queue first).
- π¦πΉAustria roromedia Linz
HI, it is not an issue with the token browser that it gets slow - it is more the way it is integrated in the form here. It would be better to just make a link instead load it fully.
- π¬π§United Kingdom MrDaleSmith
Like I say, that's how the Core token module is generating it: this isn't our code to change or an issue we can resolve.
- π¦πΉAustria roromedia Linz
I think there is a misunderstanding, what I try to point out is that it should be done differently (as webform is doing it), like here the "Browse available token" link - if webform would always load the full token browser on every AJAX settings panel for each field it would be unusable: https://pasteboard.co/dkCzHcfW9z8c.png
- π¬π§United Kingdom MrDaleSmith
You are right and I am wrong: the automator isn';t using core's recommended method for rendering the token help but is directly rendering a Token module's token tree on the page.
- π¦πΉAustria roromedia Linz
Thank you for investigating that issue further - that makes sense why it slows down at this point. Let's keep this issue open until it is resolved. It isn't critical as it doesn't break functionality it is just annoyingly slow currently for quick edits.
- Merge request !318Improve token support, remove unnecessary code and fix coding standards. β (Merged) created by MrDaleSmith
- π©πͺGermany marcus_johansson
Thank your for cleaning up the code Paul and for fixing this. Code wise it looks good, Roland could you test the actual functionality changes before we merge?
- π¦πΉAustria roromedia Linz
Hi Marcus, I patched the ai module and can confirm that it works - now I am getting a "Browse available tokens" link and the token modal - beautiful, much faster to do tweaks regardless of the field count in the installation.
Automatically closed - issue fixed for 2 weeks with no activity.