Allow other modules to include their own Navigation blocks during installation

This would be super useful for a bunch of modules. Not having this logic in navigation means having to duplicate it elsewhere (dashboard that I'm aware, potentially workspaces, environment indicator, etc).

Added some comments, but nothing should be blocking. New feature has test coverage.

Hope this can make it to 11.1.

LGTM then.

Wondering if there should be an issue for adding the 'plugin.manager.config_action' service to core.services.yml to allow autowiring or if this was intentional.

This is not strictly speaking a Drupal CMS blocker as there are workarounds, but definitely is a nice to have.

Neat!

Just remembered about $is_syncing. We don't want duplicated blocks.

I did not realize until you mentioned it. Great catch!

Changes added to the MR.

Back to RTBC

Left some minor feedback on the MR, this is really nice!

Thank you for your review @larowlan. I think the feedback has been addressed.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Back to RTBC once conflicts have been solved.

Committed to 11.x - thanks
Discussed backport with @catch and decided not needed because this isn't a stable blocker

larowlan → closed merge request !10424

Automatically closed - issue fixed for 2 weeks with no activity.