- Issue created by @plopesc
- Merge request !10424Issue #3491081: Allow other modules to include their own Navigation blocks during installation → (Open) created by plopesc
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
This would be super useful for a bunch of modules. Not having this logic in navigation means having to duplicate it elsewhere (dashboard that I'm aware, potentially workspaces, environment indicator, etc).
Added some comments, but nothing should be blocking. New feature has test coverage.
Hope this can make it to 11.1.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
LGTM then.
Wondering if there should be an issue for adding the 'plugin.manager.config_action' service to core.services.yml to allow autowiring or if this was intentional.
This is not strictly speaking a Drupal CMS blocker as there are workarounds, but definitely is a nice to have.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Just remembered about $is_syncing. We don't want duplicated blocks.
- 🇪🇸Spain plopesc Valladolid
I did not realize until you mentioned it. Great catch!
Changes added to the MR.