Contrib.social

Allow vlsuite demo /shuttle to be installed through recipes

Open on Drupal.org →
Created on 29 November 2024, 19 days ago

Problem/Motivation

There are several errors found when a recipe install vlsuite_demo or vlsuite_shuttle:

  • There were validation errors in block_content.type.vlsuite_cta:
    - description: This value should not be blank.
  • Invoking hook_config_schema_info_alter() has added (block_content.type.*) schema definitions
  • Call to a member function getConfigDependencyName() on null in Drupal\Core\Entity\EntityDisplayBase->calculateDependencies()

Steps to reproduce

Install a recipe like this:


name: 'VlSuite'
description: "Recommended media modules"
type: 'DXPR'

install:
  - vlsuite_demo

config:
  import:
      vlsuite: '*'
      vlsuite_animations: '*'
      vlsuite_block: '*'
      vlsuite_block_attachments: '*'
      vlsuite_block_cta: '*'
      vlsuite_block_headings_menu: '*'
      vlsuite_block_icon: '*'
      vlsuite_block_image: '*'
      vlsuite_block_local_video: '*'
      vlsuite_block_remote_video: '*'
      vlsuite_block_text: '*'
      vlsuite_block_webform: '*'
      vlsuite_bundle_field: '*'
      vlsuite_collection: '*'
      vlsuite_collection_card: '*'
      vlsuite_collection_gallery: '*'
      vlsuite_collection_hero: '*'
      vlsuite_collection_stmt: '*'
      vlsuite_format: '*'
      vlsuite_icon_font: '*'
      vlsuite_layout: '*'
      vlsuite_layout_builder: '*'
      vlsuite_layout_tabs: '*'
      vlsuite_media: '*'
      vlsuite_media_document: '*'
      vlsuite_media_icon: '*'
      vlsuite_media_image: '*'
      vlsuite_media_local_video: '*'
      vlsuite_media_remote_video: '*'
      vlsuite_modal: '*'
      vlsuite_slider: '*'
      vlsuite_utility_classes: '*'

Proposed resolution

  • Alter block type configuration through schema.yaml
  • Add block type descriptions as null instead of empty string
✨ Feature request
Status

Active

Version

2.2

Component

Code

Created by

🇪🇸Spain omarlopesino

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @omarlopesino
  • Comment 19 days ago →
    🇪🇸Spain omarlopesino
  • Comment 19 days ago →
    🇪🇸Spain omarlopesino
  • Merge request !55Draft: Resolve #3490677 "Allow vlsuite demo" → (Open) created by omarlopesino
  • Pipeline finished with Success
    16 days ago
    Total: 161s
    #356302
  • Pipeline finished with Success
    16 days ago
    Total: 192s
    #356447
  • Comment 16 days ago →
    🇪🇸Spain omarlopesino

    I've pushed the initial changes that makes the module compatible:

    • Block type descriptions are now null instead of empty string.
    • Vlsuite block icon now is a third party setting, which is the recommended way → to add additional configuration to config entities.
    • Filter settings installed by vlsuite are updated according to current schema.

    The rest of problems found were either problems from the self recipe.yml that have been fixed, or Drupal Recipe API existing issues.

    Pending work (thanks crzdev for the feedback):

    • Manual review of vlsuite block icon configuration / display
    • Implement hook update so that existing sites does not lose their vlsuite block icon configuration.
  • Pipeline finished with Success
    16 days ago
    Total: 195s
    #356577
  • Pipeline finished with Success
    16 days ago
    Total: 179s
    #356586
  • Pipeline finished with Success
    16 days ago
    Total: 170s
    #356606
  • Pipeline finished with Success
    16 days ago
    Total: 267s
    #356615
  • Comment 16 days ago →
    🇪🇸Spain omarlopesino

    I've made all the pending changes and now the vlsuite demo installation through recipes have been successsful.

    This is ready to be reviewed.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024