- Issue created by @jan kellermann
- π©πͺGermany jan kellermann
If we change the attrbute to "role", the error "Uses ARIA roles on incompatible elements" occurs.
Maybe the use of the "role"-attribute for the label-element is wrong because the label is via attributes associated to the input-element.
- π©πͺGermany rkoller NΓΌrnberg, Germany
jan kellermann β credited rkoller β .
- π©πͺGermany jan kellermann
Todos after discussing in slack #accessibility:
- Move tabindex from label to input field
- Move aria-checked from label to input field
- Remove role from label
- π©πͺGermany rkoller NΓΌrnberg, Germany
the checkbox doesnt need a tabindex, checkboxes are already included in the tabindex out of the box, same for aria-checked. if you take another look at the video i've shared on slack, there you notice that the checkbox is already tab-able (it is just missing a visible focusoutline) and it is already announced as unchecked. so i think tabindex and aria-checked have simply to be removed from the label instead of moving them over to the input element.
- π©πͺGermany jan kellermann
Thank @rkoller.
The focus-outline was missing, I added this to CSS.
The tabindex-attribute for input element is needed - else the element-order is wrong.I opened a MR. Please review.
-
jan kellermann β
committed c09f7c7d on 3.x
#3490656: Fix aria for checkboxes.
-
jan kellermann β
committed c09f7c7d on 3.x