EntityConstraintViolationList::addAll doesn't reset groupings

Created on 29 November 2024, 19 days ago

Problem/Motivation

\Symfony\Component\Validator\ConstraintViolationList::addAll simply adds to the existing violations property and doesn't call the individual ::add method.
This means calling addAll on \Drupal\Core\Entity\EntityConstraintViolationList doesn't reset violationOffsetsByField and entityViolationOffsets like calling ::add does

Steps to reproduce

Proposed resolution

Implement ::addAll in \Drupal\Core\Entity\EntityConstraintViolationList and have it reset the two properties then call the parent
Write a test to validate it works

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

entity system

Created by

🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

Live updates comments and jobs are added and updated live.

Merge Requests

!10390EntityConstraintViolationList::addAll doesn't reset groupings
Open
🇮🇳India harivansh
updated 19 days ago

Comments & Activities

Issue created by @larowlan
First commit to issue fork.
Merge request !103903490588-entityconstraintviolationlistaddall-doesnt-reset: Added the addAll... → (Open) created by harivansh
Comment 19 days ago →
🇮🇳India harivansh
Pipeline finished with Failed
19 days ago
Total: 89s
#353930
Pipeline finished with Failed
19 days ago
Total: 581s
#353931
Comment 19 days ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Thanks for working on this @harivansh, this is looking great, just a couple of comments about the test - we need to call something to group the violations before we call addAll

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024