- Issue created by @dahousecat
- 🇬🇧United Kingdom dahousecat
I did try and create an MR but I'm having some issues with permissions when pushing and it's late so will just attach a patch for now.
- First commit to issue fork.
- 🇯🇵Japan ptmkenny
ptmkenny → changed the visibility of the branch 3490555-support-seralization-of to hidden.
- 🇯🇵Japan ptmkenny
Thanks for this issue. For the serializer, I think it will be safe to accept PublicKeyCredentialOptions, so I created an MR to do that.
Please review and let me know if this solves your issue.
Passing that into simplewebauthn/browser startRegistration() resulted in "TypeError: base64URLString is undefined"
I'm guessing that's because webauthn-lib 5 no longer serializes to JSON objects, so that's not "supposed" to work anymore? I do not know why this change was made, but this module is attempting to follow the underlying library as closely as possible.
Here's the relevant page from the docs: https://webauthn-doc.spomky-labs.com/pure-php/authenticator-registration
- 🇬🇧United Kingdom dahousecat
Hi, thanks for the swift reply :)
The MR looks good to me, better than my patch as simpler.
Yes, it's a shame this update has so many breaking changes but thanks for the pointer - I'll review the updated documentation.
-
ptmkenny →
committed 25077371 on 1.0.x
Issue #3490555 by dahousecat, ptmkenny: Support seralization of...
-
ptmkenny →
committed 25077371 on 1.0.x
- 🇯🇵Japan ptmkenny
Thanks for the review!
Yes, there are a lot of breaking changes; I need to do more testing before I make a new release with 5.x support.
Automatically closed - issue fixed for 2 weeks with no activity.