Test profiles should be in a tests directory

So I had to adjust a handful of tests with hard-coded paths.

QuickStartCommand unit test needs to use a real profile - there is no simpletest UA header when it runs so now the testing profile (rightly!) doesn't get discovered.

Otherwise this has been possible the whole time, we just hadn't done it.

Should save a millisecond or so on every cold cache on every site.

This seems great. Summary and comments all make sense. MR looks good.

However, one last Kernel test to fix:

 System Listing (Drupal\Tests\system\Kernel\Common\SystemListing)
     ✘ Directory precedence
       ┐
       ├ Failed asserting that file "/builds/project/drupal/core/profiles/testing/modules/drupal_system_listing_compatible_test/drupal_system_listing_compatible_test.info.yml" exists.
       │
       │ /builds/project/drupal/core/modules/system/tests/src/Kernel/Common/SystemListingTest.php:38
       ┴
     ✔ File scan ignore directory
    
    FAILURES!
    Tests: 2, Assertions: 3, Failures: 1.

I'm not totally sure this is a bug, not a task, but I don't want to die on that hill. 😅 But if it's a bug, let's smash it.

My local env isn't setup for 11.x tests right now, but I think I fixed it. Let's see what the bot says...

Bot is indeed happy. That commit seems like such a minor and obvious change to the MR, I'm going to be bold and go ahead and RTBC this. If the committer is unhappy about it, we can presumably get a quick re-RTBC from someone else. 😅

Thanks!
-Derek

Plus 1 rtbc. I thought it was strange when working on the profile hook issue.

I also think this will close: #3076329: ExtensionDiscovery returns testing profiles even when you ask it not to →

catch → credited baysaa → .

catch → credited daffie → .

catch → credited jhodgdon → .

Oh yeah this is technically a duplicate of that one, but since the patch there is from several years ago we can probably close that issue. Moving credit over.

Committed and pushed 7f8c55c9c5b to 11.x and 6cfb39aaf98 to 11.1.x. Thanks!

The move of locations broke 🐛 Ensure run-tests.sh and PHPUnit CLI run with the same list of tests to be executed Active - which is correct. Rebased that.

Automatically closed - issue fixed for 2 weeks with no activity.