- Issue created by @leymannx
- leymannx Berlin
I was just following the existing logic while keeping it extendable at the same time, adding a new section "Notification messages" at the end of the config form to set just a "Stuck message" for now. In all places it falls back to the existing messages which already existed.
- 🇪🇸Spain fjgarlin
We don't have tests in the module, but I've reviewed the code and it does look good and there is no regression. Thanks for this!
-
fjgarlin →
committed d9b4f5cc on 1.x authored by
leymannx →
Issue #3489204 by leymannx: Make stuck migrations message configurable
-
fjgarlin →
committed d9b4f5cc on 1.x authored by
leymannx →
- 🇪🇸Spain fjgarlin
A nice follow-up for this module might be to create a
config/schema/migration_notify.schema.yml
file, which I think might be required in future versions of Drupal, but don't worry if you don't have the time. I appreciate the fixes. - leymannx Berlin
Yeah, I thought the exact same about the schema. Follow-up issue and I'm happy to help here. 🤝
- 🇪🇸Spain fjgarlin
Awesome! Thanks so much!
In case this other module might be useful, I'm just putting it out here: https://www.drupal.org/project/config_notify →
I actually created the above first, and then had the idea for this one. They follow very similar principals. - leymannx Berlin
You mean we might also add this feature of a configurable message there as well?
- 🇪🇸Spain fjgarlin
If you want 🙂
I think that module might have some more settings but can’t remember if messages were configurable.
- 🇪🇸Spain fjgarlin
But it was mostly to bring the module under your radar too in case it wasn’t.
Automatically closed - issue fixed for 2 weeks with no activity.