Support for entityqueue views plugin inside workspaces

Created on 22 November 2024, 4 months ago

Problem/Motivation

The views relationship plugin doesn't work inside workspaces because it doesn't join the entity queue items revision data and has no condition/join for the current workspace.

Steps to reproduce

TBD.

Proposed resolution

Add an new relationship handler that joins queue items revision data and workspaces as necessary.

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Active

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @s_leu
  • Merge request !31Resolve #3489180 "Workspace support" → (Merged) created by s_leu
  • Pipeline finished with Failed
    4 months ago
    Total: 169s
    #346945
  • Pipeline finished with Failed
    4 months ago
    Total: 149s
    #351692
  • Pipeline finished with Failed
    4 months ago
    Total: 153s
    #351697
  • Pipeline finished with Failed
    4 months ago
    Total: 205s
    #351719
  • Pipeline finished with Failed
    4 months ago
    Total: 319s
    #351823
  • 🇷🇴Romania amateescu

    Looked at this for a long time, and I think it should be fixed with a combination of changes in core Workspaces and our custom relationship handler, but I couldn't get to an actual proposal yet, so let's go with what we have here if it works.

    I'd like to see a few changes to the MR though: in order to allow this fix to be applied without having to do any manual config updates on existing sites, let's put all the new code in the existing relationship handler, inside additional methods that kick in only if the workspaces module is enabled and if there's an active workspace.

  • Pipeline finished with Failed
    4 months ago
    Total: 144s
    #359815
  • Thanks for the review, I addressed the feedback.

  • Pipeline finished with Skipped
    4 months ago
    #360036
  • 🇷🇴Romania amateescu

    Still hoping that this is a temporary solution.. merged into 8.x-1.x, thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • 🇵🇹Portugal joao.ramos.costa

    Hi everyone,

    still investigating but I think there's some issues when commit b124c65a introduced entityqueue_views_query_alter.
    1 - This line if (\in_array('entityqueue_relationship', $join_ids, TRUE)) { :
    It should look for relationship plugin 'id' and not for its key as we might have more than one relationship where _n is appended.
    2 - The expression $subquery->addExpression("MAX($revision_table.{$keys['revision']})", $keys['revision']);
    Doesn't seem to take into account when 'limit_queue' option from entity_queue ViewsRelationship is set, or more than an entity_queue, I guess.
    3- entity_subqueue_revision table doesn't include the parent queue, in case of a subqueue set as 'limit_queue', so it makes dificult to add a condition clause here too.

Production build 0.71.5 2024