Contrib.social

Rename NodeHooks1 to something meaningful

Open on Drupal.org →
Created on 22 November 2024, 5 months ago

Problem/Motivation

The new class NodeHooks1 does not follow the coding standard that states,

Classes and interfaces should have names that stand alone to tell what they do without having to refer to the namespace, read well, and are as short as possible without losing functionality information or leading to ambiguity.

Steps to reproduce

Proposed resolution

TBD
Can there be just one NodeHooks?

Remaining tasks

MR
Review
Commit
Document the convention used for naming these hook classes

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

base system

Created by

🇳🇿New Zealand quietone

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @quietone
  • Comment 5 months ago →
    🇺🇸United States nicxvan

    This is an artifact of us covering two hooks in the original issue.

    Rector had logic to prevent overwriting or adding to an existing file.

    I think this can be handle two ways.

    One just move everything to node hooks

    Or split them.

    There isn't a specific standard yet but workspace made some great progress (though I disagree with making them final)

  • Status changed to Closed: duplicate about 1 month ago
  • Comment about 1 month ago →
    🇳🇿New Zealand quietone

    Closing as a duplicate of 📌 Remove NodeHooks1 Active

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024