- Issue created by @pameeela
- πΊπΈUnited States phenaproxima Massachusetts
Well...it's not hardcoded, exactly; it looks like it's a layout section, so once Layout Builder has config actions to manipulate a section, we should be able to remove it that way.
- π¦πΊAustralia pameeela
But in the meantime I think we need to modify our import so it's not there? It's a broken link
- πΊπΈUnited States eojthebrave Minneapolis, MN
Related (not sure if this needs a different issue or not) there's a link on the default dashboard for "Learn to build with Drupal" which is now broken because Help module is no longer installed.
- π¦πΊAustralia pameeela
@eojthebrave oh, thanks! Those are just placeholders, but we should remove the broken link anyway.
I think I might have fixed this, let's see.
- πΊπΈUnited States phenaproxima Massachusetts
Yay, glad you were able to crush it! I have a couple of changes to request, and if it still works after making them, go ahead and kick this to RTBC.
- π¦πΊAustralia pameeela
Oh I thought we had to specify if we aren't using the wildcard? If we just use the Navigation config then we get the help link. Or do we only have to copy over the block config which is being modified?
- π¦πΊAustralia pameeela
Yeah ok, we don't need to list
navigation.settings
but we do need to providesystem.menu.content
otherwise we get this:I figured it's because the config file isn't
navigation.something
?I'll double check this after the build finishes then RTBC.
- πΊπΈUnited States phenaproxima Massachusetts
@pameeela π€ I tried this locally and we don't need to copy the
content
menu into the recipe for the Help link to be gone. I tested it manually and added automated coverage to be safe.I think this is good to go.
- πΊπΈUnited States phenaproxima Massachusetts
Crediting @eojthebrave for pointing out the broken link which is removed by this MR.
-
phenaproxima β
committed 50b787f5 on 0.x authored by
pameeela β
Issue #3488292 by pameeela, phenaproxima, eojthebrave: Remove Help link...
-
phenaproxima β
committed 50b787f5 on 0.x authored by
pameeela β
- πΊπΈUnited States phenaproxima Massachusetts
Whew, merged into 0.x. Let's gooo!
- π¦πΊAustralia pameeela
Thatβs so weird. I was using the Tugboat sites. Wonder if something is different about them?
Automatically closed - issue fixed for 2 weeks with no activity.