Help link is hardcoded in Navigation block

Created on 19 November 2024, 5 months ago

Problem/Motivation

The 'Help' link is hardcoded in navigation.block_layout.yml, meaning it appears in the sidebar regardless of whether the module is installed.

We recently decided not to install it in πŸ“Œ Don't install help module by default Active , but the link is still there and leads to a 404.

Proposed resolution

I guess we have to provide modified config instead of using the wildcard?

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Component

Base Recipe

Created by

πŸ‡¦πŸ‡ΊAustralia pameeela

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @pameeela
  • πŸ‡¦πŸ‡ΊAustralia pameeela
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Well...it's not hardcoded, exactly; it looks like it's a layout section, so once Layout Builder has config actions to manipulate a section, we should be able to remove it that way.

  • πŸ‡¦πŸ‡ΊAustralia pameeela

    But in the meantime I think we need to modify our import so it's not there? It's a broken link

  • Merge request !218Specify navigation config to remove Help link β†’ (Merged) created by pameeela
  • Pipeline finished with Canceled
    4 months ago
    Total: 320s
    #345820
  • Pipeline finished with Failed
    4 months ago
    Total: 771s
    #345834
  • Pipeline finished with Failed
    4 months ago
    Total: 1065s
    #345837
  • πŸ‡¦πŸ‡ΊAustralia pameeela

    This breaks the navigation quite badly!

  • Pipeline finished with Failed
    4 months ago
    Total: 1207s
    #345881
  • Pipeline finished with Success
    4 months ago
    Total: 1224s
    #345879
  • πŸ‡ΊπŸ‡ΈUnited States eojthebrave Minneapolis, MN

    Related (not sure if this needs a different issue or not) there's a link on the default dashboard for "Learn to build with Drupal" which is now broken because Help module is no longer installed.

  • πŸ‡¦πŸ‡ΊAustralia pameeela

    @eojthebrave oh, thanks! Those are just placeholders, but we should remove the broken link anyway.

    I think I might have fixed this, let's see.

  • Pipeline finished with Failed
    4 months ago
    Total: 864s
    #346573
  • Pipeline finished with Failed
    4 months ago
    Total: 1243s
    #346572
  • πŸ‡¦πŸ‡ΊAustralia pameeela

    Yeehaw, it works!

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Yay, glad you were able to crush it! I have a couple of changes to request, and if it still works after making them, go ahead and kick this to RTBC.

  • πŸ‡¦πŸ‡ΊAustralia pameeela

    Oh I thought we had to specify if we aren't using the wildcard? If we just use the Navigation config then we get the help link. Or do we only have to copy over the block config which is being modified?

  • πŸ‡¦πŸ‡ΊAustralia pameeela

    Yeah ok, we don't need to list navigation.settings but we do need to provide system.menu.content otherwise we get this:

    I figured it's because the config file isn't navigation.something?

    I'll double check this after the build finishes then RTBC.

  • Pipeline finished with Canceled
    4 months ago
    Total: 520s
    #346589
  • Pipeline finished with Canceled
    4 months ago
    Total: 527s
    #346590
  • πŸ‡¦πŸ‡ΊAustralia pameeela

    And all working now.

  • Pipeline finished with Failed
    4 months ago
    Total: 876s
    #346597
  • Pipeline finished with Failed
    4 months ago
    Total: 990s
    #346596
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    @pameeela πŸ€” I tried this locally and we don't need to copy the content menu into the recipe for the Help link to be gone. I tested it manually and added automated coverage to be safe.

    I think this is good to go.

  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Crediting @eojthebrave for pointing out the broken link which is removed by this MR.

  • Pipeline finished with Failed
    4 months ago
    Total: 643s
    #347070
  • Pipeline finished with Failed
    4 months ago
    Total: 632s
    #347084
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Pipeline finished with Failed
    4 months ago
    Total: 991s
    #347095
  • Pipeline finished with Failed
    4 months ago
    Total: 1129s
    #347107
  • Pipeline finished with Skipped
    4 months ago
    #347138
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

    Whew, merged into 0.x. Let's gooo!

  • πŸ‡¦πŸ‡ΊAustralia pameeela

    That’s so weird. I was using the Tugboat sites. Wonder if something is different about them?

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024