Contrib.social

Computed fields should be excluded from the diff

Open on Drupal.org →
Created on 19 November 2024, about 1 month ago

Problem/Motivation

Computed fields are not available to be configured on "/admin/config/content/diff/fields" but are used in the diff overview of an entity.
The form on "/admin/config/content/diff/fields" is built with with the entity field manager's getFieldStorageDefinitions() which does not return computed fields.
The entity diff overview (ex "/node/123/revisions/view/456/789/split_fields" iterates through all of the $entity's fields.

Steps to reproduce

Create a computed field and see that it shows on the diff.

Proposed resolution

Exclude computed fields from the diff display.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States recrit

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @recrit
  • Merge request !117Issue #3488283: Computed fields should be excluded from the diff → (Open) created by recrit
  • Comment about 1 month ago →
    🇺🇸United States recrit
  • Pipeline finished with Failed
    about 1 month ago
    Total: 211s
    #342814
  • Comment about 1 month ago →
    🇺🇸United States recrit

    The MR build is failing for phpstan errors unrelated to the 1 line change in the MR.
    Error from phpstan:

     ------ ------------------------------------------------------------------------------------------------------ 
  Line   src/Controller/NodeRevisionController.php                                                             
 ------ ------------------------------------------------------------------------------------------------------ 
         Ignored error pattern #^Method                                                                        
         Drupal\\Core\\Form\\FormBuilderInterface\:\:getForm\(\) invoked with                                  
         2 parameters, 1 required\.$# in path                                                                  
         /builds/issue/diff-3488283/web/modules/custom/diff-3488283/src/Controller/NodeRevisionController.php  
         was not matched in reported errors.                                                                   
 ------ ------------------------------------------------------------------------------------------------------
  • Comment 5 days ago →
    heddn Nicaragua

    Can we add tests?

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024