Contrib.social

Error messages while checking for new translations

Open on Drupal.org →
Created on 18 November 2024, 10 months ago

When I try to check for new translations, several watchdog messages are triggered and the check process is aborted.

Warning: Attempt to read property "directory" on bool in locale_translation_source_check_file() (Zeile 175 in /var/www/html/docroot/core/modules/locale/locale.translation.inc)

This causes some follow-up errors, but the main problem is that not a file is returned from the array, but a FALSE due to no local file being available. Adding a simple check solves the problem. The question is though if its a local issue in my test system or does it need to be treated in core?

function locale_translation_source_check_file($source) {
  if (isset($source->files[LOCALE_TRANSLATION_LOCAL])) {
    $source_file = $source->files[LOCALE_TRANSLATION_LOCAL];
++    if ($source_file) {
      $directory = $source_file->directory;
      $filename = '/' . preg_quote($source_file->filename) . '$/';

      if (is_dir($directory)) {
        if ($files = \Drupal::service('file_system')->scanDirectory($directory, $filename, ['key' => 'name','recurse' => FALSE])) {
          $file = current($files);
          $source_file->uri = $file->uri;
          $source_file->timestamp = filemtime($file->uri);
          return $source_file;
        }
++      }
    }
  }
  return FALSE;
}
🐛 Bug report
Status

Active

Version

10.3 ✨

Component

locale.module

Created by

🇩🇪Germany Rudi Teschner

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024