New navigation does not displace if detached and attached again

Created on 16 November 2024, 5 days ago

Problem/Motivation

The new navigation's JavaScript seems to have an all or nothing approach to displacement in the sense that displacement is bundled up with other changes that are all wrapped in a once() on the document.documentElement and it doesn't have a detach once.remove() to then allow a subsequent attach to apply. You might be wondering why this is an issue? It breaks displacement when navigating around the admin section using the RefreshLess module , which swaps out the page contents without any full page loads, and thus needs working behaviour detach callbacks to clean up before it swaps in a new page.

Steps to reproduce

See above.

Proposed resolution

Move the displacement stuff to its own behaviour.

Remaining tasks

Do the thing.

User interface changes

Displacement should now work.

Introduced terminology

None.

API changes

None?

Data model changes

None.

Release notes snippet

???

🐛 Bug report
Status

Active

Version

11.1 🔥

Component

navigation.module

Created by

🇨🇦Canada ambient.impact Toronto

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024