Replace \PDO::FETCH_* constants to indicate fetch mode with an enumeration

Created on 15 November 2024, 6 days ago

Problem/Motivation

TBD

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

database system

Created by

🇮🇹Italy mondrake 🇮🇹

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mondrake
  • Pipeline finished with Failed
    6 days ago
    Total: 142s
    #340276
  • Pipeline finished with Failed
    6 days ago
    Total: 714s
    #340281
  • 🇮🇹Italy mondrake 🇮🇹
  • Pipeline finished with Failed
    5 days ago
    Total: 140s
    #340387
  • Pipeline finished with Failed
    5 days ago
    Total: 1792s
    #340388
  • Pipeline finished with Failed
    5 days ago
    Total: 204s
    #340821
  • Pipeline finished with Failed
    5 days ago
    Total: 1096s
    #340825
  • Pipeline finished with Failed
    4 days ago
    Total: 142s
    #341288
  • Pipeline finished with Failed
    4 days ago
    Total: 1053s
    #341293
  • Pipeline finished with Failed
    4 days ago
    Total: 146s
    #341322
  • Pipeline finished with Failed
    4 days ago
    Total: 1431s
    #341416
  • Pipeline finished with Failed
    3 days ago
    Total: 127s
    #341454
  • Pipeline finished with Success
    3 days ago
    Total: 1475s
    #341455
  • 🇮🇹Italy mondrake 🇮🇹
  • Pipeline finished with Success
    3 days ago
    Total: 1314s
    #342152
  • 🇮🇹Italy mondrake 🇮🇹
  • 🇳🇱Netherlands daffie

    For the change record and the questions on the MR.

  • Pipeline finished with Failed
    2 days ago
    Total: 609s
    #343317
  • Pipeline finished with Failed
    1 day ago
    Total: 133s
    #343752
  • 🇮🇹Italy mondrake 🇮🇹
  • Pipeline finished with Success
    1 day ago
    Total: 1205s
    #343756
  • Pipeline finished with Failed
    1 day ago
    Total: 130s
    #343940
  • 🇮🇹Italy mondrake 🇮🇹

    Follow up: 📌 [PP-1] Introduce a StatementBase abstract class Postponed , to create a common base class for statement objects.

  • 🇳🇱Netherlands daffie

    The CI pipeline is not happy.

  • Pipeline finished with Failed
    1 day ago
    Total: 205s
    #343966
  • Pipeline finished with Failed
    1 day ago
    Total: 128s
    #343975
  • 🇮🇹Italy mondrake 🇮🇹

    Juggled a bit with typehints.

  • Pipeline finished with Success
    1 day ago
    Total: 4929s
    #343982
  • 🇳🇱Netherlands daffie

    All the code change good to me.
    I have updated the CR and the IS.
    The CI pipeline is green for all by core supported databases.
    All my questions have been answered.
    For me it is RTBC.

  • 🇮🇹Italy mondrake 🇮🇹

    Thanks for review @daffie!

  • 🇮🇹Italy mondrake 🇮🇹

    I'm still trying to do some tuning with the typehints in PdoTrait - to make them as accurate and PHPStan-proof as possible. It may turn out that CodeSniffer will be unhappy, in which case I think we should silence its failures.

  • 🇮🇹Italy mondrake 🇮🇹

    Changes to return typehints were OK for CodeSniffer, good - but now this needs review again I suppose, sorry @daffie

  • Pipeline finished with Failed
    about 24 hours ago
    Total: 965s
    #344380
  • 🇮🇹Italy mondrake 🇮🇹

    Stricter typing is highlighting a bug. On that.

  • Pipeline finished with Failed
    about 24 hours ago
    Total: 116s
    #344416
  • 🇮🇹Italy mondrake 🇮🇹

    Reviewable again.

  • Pipeline finished with Success
    about 21 hours ago
    Total: 3804s
    #344530
  • 🇳🇱Netherlands daffie

    All looks good to me.
    Back to RTBC.

Production build 0.71.5 2024