- Issue created by @mondrake
- Merge request !10207Replace \PDO::FETCH_* constants to indicate fetch mode with an enumeration → (Open) created by mondrake
- 🇳🇱Netherlands daffie
For the change record and the questions on the MR.
- 🇮🇹Italy mondrake 🇮🇹
Follow up: 📌 [PP-1] Introduce a StatementBase abstract class Postponed , to create a common base class for statement objects.
- 🇳🇱Netherlands daffie
All the code change good to me.
I have updated the CR and the IS.
The CI pipeline is green for all by core supported databases.
All my questions have been answered.
For me it is RTBC. - 🇮🇹Italy mondrake 🇮🇹
I'm still trying to do some tuning with the typehints in PdoTrait - to make them as accurate and PHPStan-proof as possible. It may turn out that CodeSniffer will be unhappy, in which case I think we should silence its failures.
- 🇮🇹Italy mondrake 🇮🇹
Changes to return typehints were OK for CodeSniffer, good - but now this needs review again I suppose, sorry @daffie
- 🇮🇹Italy mondrake 🇮🇹
Stricter typing is highlighting a bug. On that.