Stale rejections block transition

Open on Drupal.org →

Created on 15 November 2024, 5 months ago

Problem/Motivation

Stale rejections block transition.

Steps to reproduce

Create a workspace
Add content to workspace
Submit the workspace to 2 reviewers
Have reviewer 1 reject the content
Have reviewer 2 approve the content
Submit the content again to the same reviewers (simulating a submission after changes were made to address the rejection)
Have both reviewer 1 and reviewer 2 approve the content
Navigate to Workspace Workflow and the transition state is still Draft and "Submit for Legal Review" is NOT available to change the state
Navigate to Workspace Approvals and Approve the original Rejection
The workspace now changes state and Submit For Legal Review

Proposed resolution

Unpublish the stale review requests. This keeps them for audit purposes, but the are no longer publically viewable.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

heddn Nicaragua

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!17Stale rejections block transition
Merged
heddn
updated 5 months ago

Comments & Activities

Issue created by @heddn
Merge request !17Resolve #3487813 "Stale rejections block transition" → (Merged) created by heddn
Comment 5 months ago →
heddn Nicaragua
Looking at the code, the original intent was to always re-use a review. This is a bug that can easily be fixed.
Comment 5 months ago →
heddn Nicaragua
Pipeline finished with Skipped
5 months ago
#344802

Comment 5 months ago →

heddn → committed 5990a66a on 1.0.x

Issue #3487813 by heddn, marvil07: Stale rejections block transition

Comment 5 months ago →
🇵🇪Peru marvil07
heddn → credited marvil07 → .
Comment 5 months ago →
heddn Nicaragua
I've opened 📌 Add option on the approval type to decide if the set of approvals needs to be an AND or an OR Active for a follow-up.
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024