- Issue created by @mstrelan
- Merge request !10198Add void return type to all *_alter hook implementations β (Closed) created by mstrelan
- π¦πΊAustralia mstrelan
This has exposed a few alter hooks that are erroneously returning something.
- πΊπΈUnited States nicxvan
Looks good!
Great catch on the ones that returned values.
-
quietone β
committed 9e0897a7 on 11.1.x
Issue #3487666 by mstrelan, nicxvan: Add void return type to all *_alter...
-
quietone β
committed 9e0897a7 on 11.1.x
-
quietone β
committed 55fd8379 on 11.x
Issue #3487666 by mstrelan, nicxvan: Add void return type to all *_alter...
-
quietone β
committed 55fd8379 on 11.x
- π³πΏNew Zealand quietone
@mstrelan, thanks for the quick turn around. I was just finishing my review earlier when we had a power outage so this had to wait a bit.
Committed to 11.x and 11.1.x.
Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.