- Issue created by @srdtwc
- πΊπΈUnited States smustgrave
this actually needs some major refactoring
- πΊπΈUnited States smustgrave
So no secret and we got permission to do so but this was forked from ckeditor_bs_grid and bootstrap has container options.
So here we need to to turn that default option to a checkbox to add the container.
Move the container class to that Div vs uswds_grid which isnβt a real uswds class
- Merge request !91Issue #3487334 by srdtwc, smustgrave: Container Wrapper Classes removed on next save β (Merged) created by smustgrave
-
smustgrave β
committed f034d997 on 3.1.x
Issue #3487334 by srdtwc, smustgrave: Container Wrapper Classes removed...
-
smustgrave β
committed f034d997 on 3.1.x
- πΊπΈUnited States smustgrave
Put a warning in the description this was a re write
- πΊπΈUnited States srdtwc Skokie, IL
There seem to be a few issues with this upgrade
1) There are a number of errors present. These appear even after a "drush cr".
2) After creating a page with a grid the wrapper classes are saved successfully, but when I go to edit the grid again a large black triangle appears in CKEditor. I can confirm this did not happen in 3.1.2.
3) Embedded Content appears broken. Any page with an existing Accordion returns an error like this:
Additionally, when clicking the "Embedded Content" button when creating a new node, there is a 500 error in the console.
- πΊπΈUnited States smustgrave
I don't understand how #1 and #3 are related to this issue
- πΊπΈUnited States srdtwc Skokie, IL
Tested again, 1 and 3 were the result of upgrading with
--with-dependencies
, which upgraded doctrine/deprecations to and caused those errors.2 is still present when upgrading without
--with-dependencies
.But I can confirm the intended functionality of being able to save the wrapper classes seems to be working.