Audit the starter recipe

Some thoughts right off the bat:

• The starter recipe includes the toolbar module. Do we really need this? I feel like this is just a holdover from the prototype, which was partially based on what Standard does. Why not just remove Toolbar in favor of Navigation?
• The Trash module should be enabled by drupal_cms_content_type_base.
• We are importing the "who's new" and "who's online" views from the User module. Does anybody actually use these? In any case, I don't think Drupal CMS has any particular need for them.
• We're importing several questionable views from the Node module: archive, content_recent, and glossary. What do these do? Do we need any of them?
• The drupal_cms_image_media_type recipe can probably be the one to disable the files view.
• Why does the authenticated user account need the "access user profiles" permission?

These are all product questions, so assigning to @pameeela for some product answers.

The starter recipe includes the toolbar module. Do we really need this? I feel like this is just a holdover from the prototype, which was partially based on what Standard does. Why not just remove Toolbar in favor of Navigation?

I believe Gin requires it to work with Navigation, or it did at some point. I don't know where to check the status of that but will try to find out.

The Trash module should be enabled by drupal_cms_content_type_base.
We are importing the "who's new" and "who's online" views from the User module. Does anybody actually use these? In any case, I don't think Drupal CMS has any particular need for them.
We're importing several questionable views from the Node module: archive, content_recent, and glossary. What do these do? Do we need any of them?

Agreed with all of these.

Why does the authenticated user account need the "access user profiles" permission?

No issue with removing this.

The drupal_cms_image_media_type recipe can probably be the one to disable the files view.

I have been wondering about this. I kind of get it, but also I do use the files view at times. But I can see how it might not make sense to many users.

More thoughts:

• The starter is providing shortcuts for various things provided by other recipes. These shortcuts should be moved into the relevant recipes where possible.
• We have a config action that configures nodes to use the admin theme for editing. Should we maybe move that opinion into content_type_base?
• We should probably move Toolbar, and the relevant permissions, into drupal_cms_admin_theme. It is, after all, part of the administrative UI.
• The content_editor role has permission to use Navigation, but authenticated does not. Should we change that, moving the permission grant into drupal_cms_admin_theme so that all authenticated users have permission to use Navigation? (Should we also do this for the "access toolbar" permission?)
• I think we could remove most of what's in the "This is from Standard" list from the install section of the starter's recipe.yml. Like...why do we need History? Or Config? Or Datetime (which I think is probably brought in by the Event content type, and doesn't need to be specifically enabled by the starter)?
• Should we move Contextual, Inline Form Errors, Field UI, and Views UI to drupal_cms_admin_theme?

Another thought: I think it makes sense for the content_type_base recipe to bring in the content_editor role and assign some basic permissions to it. Then the content type recipes themselves should add the relevant content type-specific permissions to that role.

Need some time to go through some of this but disagree re: authenticated users. I don't think they should get admin theme and navigation. Mostly I think of this a someone providing user-generated content e.g. comments or something and should not need any admin tools.

Another question: do we need the audio and local video media types? I feel like local video especially is dubious - do enough people self-host videos to make it worthwhile to include this core recipe in the starter?

do we need the audio and local video media types?

This should be decided by the media track/recipes, which are still to come. I believe they recommended not including them though.

Another question: the Starter recipe is applying core's user_picture recipe, which allows user accounts to have avatars. Is that desirable, you think? Or should we remove it, at least for now?

Funny, I initially thought we should remove it too, but then I realised a lot of our competitors have a profile pic: Wordpress, Wix, Weblfow and Squarespace all have this. So I guess we should keep it?

If we do not allow "access user profiles" for authenticated/anonymous users, then will the user pictures have any benefits? Probably the most common thing to display these avatars is in comments or in articles. But I am not sure if we plan to use them there.

OK - Pam and I paired on this today and now it's just a question of getting the tests to pass. Self-assigning to figure that out.

diff --git a/recipes/drupal_cms_starter/recipe.yml b/recipes/drupal_cms_starter/recipe.yml
--- a/recipes/drupal_cms_starter/recipe.yml
+++ b/recipes/drupal_cms_starter/recipe.yml
@@ -104,50 +86,34 @@ config:
-        register: admin_only

Do we want to allow registrations in Drupal CMS installations for everyone by default? I think the default is register: visitors, if the code above will be removed. This change is not mentioned in previous comments, if I have not missed anything.

🤔 Pam told me that was changed to admin_only by default in core recently, so that's why removed that line.

Yep, 📌 Make "Who can register accounts?" "Administrators only" by default Fixed

Was planning to check that it definitely applies to us, but I'm not sure as I don't see where we are explicitly installing User module? Looks like maybe just with core/recipes/user_picture in which case I guess we still need that one :) But I am still not sure where are getting user.settings from.

User is a required core module and is always installed on every Drupal site.

In that case though we are not covered by these changes because user.settigs.yml in the user module is still set to visitors. The change was only made in minimal/standard.

Oh, dang. Well, glad you caught that!

OK - I think this looks good. Not sure if @pameeela needs to review this, since we paired on it, but assigning to her anyway to give the final thumbs-up.

Reviewed with small changes:

1. Removed the user picture recipe, changed my mind about this because I think we should only add it if we are using the picture for something (and we're not now)
2. Added back config and views_ui, we discussed having a dev tools recipe but that won't happen yet and I do think there is value in an ambitious site builder discovering these tools

Also found it a bit tricky to review since some things are removed but some are relocated. If we need to tweak later, so be it!

Merged into 0.x. Thanks all!

Automatically closed - issue fixed for 2 weeks with no activity.