Contrib.social

setActiveThread is not called when loading the page private-messages

Open on Drupal.org →
Created on 12 November 2024, 9 days ago

Problem/Motivation

A common usage of Private Message is to display the Inbox block in a sidebar and the selected thread in the main content.

In these conditions, when the main page "/private-messages" is open, the first thread in the Inbox will be displayed in the main content. Thus, the first thread in the Inbox should be highlighted and for that it should have the class "active-thread". But this is not happening.

Steps to reproduce

Display the Inbox block in a sidebar and the selected thread in the main content.
Go to "/private-messages".
Check that the first thread in the Inbox is not highlighted. Also inspect the code and check that the class "active-thread" is missing in the element's <div>.

The problem is that the library "private_message_thread_script" depends on the library "inbox_block_script" for this to work correctly.
This can be seen here: https://git.drupalcode.org/project/private_message/-/blob/3.0.2/js/priva...
If Drupal.PrivateMessages.setActiveThread defined in "inbox_block_script" does not exist, Drupal.PrivateMessages.setActiveThread(originalThreadId); is not running.

This dependency is not declared in the file "private_message.library.yml" and like that the order that the libraries are loaded is not always correct.

Proposed resolution

I don't think we can set the dependency in the libraries file, since we may not want to always show the Inbox.

My proposal is to change the code so that the library "inbox_block_script"" depends on the library "private_message_thread_script".
And declare that dependency in the file "private_message.library.yml" to be sure that the files are loaded in the right order.

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇵🇹Portugal dxvargas

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dxvargas
  • Comment 9 days ago →
    🇵🇹Portugal dxvargas
  • Comment 9 days ago →
    🇵🇹Portugal dxvargas
  • Merge request !137Issue #3486915: Ensure setActiveThread is called → (Merged) created by dxvargas
  • Pipeline finished with Failed
    9 days ago
    Total: 185s
    #336714
  • Pipeline finished with Failed
    9 days ago
    Total: 182s
    #336731
  • Pipeline finished with Failed
    9 days ago
    Total: 194s
    #336778
  • Pipeline finished with Success
    9 days ago
    Total: 335s
    #336783
  • Pipeline finished with Canceled
    8 days ago
    Total: 124s
    #336956
  • Pipeline finished with Failed
    8 days ago
    Total: 182s
    #336957
  • Pipeline finished with Failed
    8 days ago
    Total: 541s
    #336961
  • Pipeline finished with Success
    8 days ago
    Total: 595s
    #336969
  • Comment 8 days ago →
    🇵🇹Portugal dxvargas

    For now I've implementing the proposed resolution and I'll wait for feedback. Moving to Needs review.

    Other options:

    1. Maybe Drupal.PrivateMessages.loadThread() could have as second argument the code to run on success. Like this we are not waiting for the result to highlight the new thread in Inbox. I think like this is the right way and also the full thread should be replaced with a timer while the new one is being loaded.
    2. Maybe a better solution would be to implement a MutationObserver logic. Like that the Inbox block would automatically react to changes in the full thread.
  • Comment 7 days ago →
    🇵🇹Portugal saidatom Lisbon

    Great! Looks good, moving to RTBC.

  • Pipeline finished with Skipped
    3 days ago
    #342301
  • Comment 3 days ago →
    🇷🇴Romania claudiu.cristea Arad 🇷🇴

    claudiu.cristea → made their first commit to this issue’s fork.

  • Comment 3 days ago →
    System Message
  • Comment 3 days ago →
    🇷🇴Romania claudiu.cristea Arad 🇷🇴

    Thank you!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024