- Issue created by @jan kellermann
- Merge request !34#3486631: Read thumbnail and title from data-attribute for contextual consent → (Merged) created by jan kellermann
- 🇩🇪Germany jan kellermann
Ic created a Merge request. Beside the code I have added example code to the README.md
What do you think, should we add the data attributes by ourselves (by option) for Media Remote Video or just provide the sample code?
- 🇩🇪Germany jurgenhaas Gottmadingen
This looks amazing and is a great new feature.
WRT preprocessing, could that be made a little more generic? I.e. checking if the media entity has a thumbnail entity. That way, we wouldn't have to hard-code the bundle name
remote_video
as that name could be different on other installations. - 🇩🇪Germany jan kellermann
I have made the code and the example a bit more general. But we should avoid exposing fields if they are not needed. More field preprocessors can be proposed as a feature request.
-
jan kellermann →
committed ec2bbfce on 3.x
#3486631: Read thumbnail and title from data-attribute for contextual...
-
jan kellermann →
committed ec2bbfce on 3.x
- 🇩🇪Germany jan kellermann
Thank you. I merged the MR (with small corrections).
Automatically closed - issue fixed for 2 weeks with no activity.