Present twice in the menu system

Created on 8 November 2024, 8 days ago

Problem/Motivation

It looks like MM is included two places in the menu system, both under Configuration > Development, but also directly under Configuration.

Steps to reproduce

Proposed resolution

Only show the MM menu in one of these places.

🐛 Bug report
Status

Active

Version

4.0

Component

Code

Created by

🇩🇰Denmark ressa Copenhagen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ressa
  • 🇷🇴Romania bbu23

    When I was working on early Drupal 11 solution the admin toolbar module was not available for Drupal 11. What I was trying to do, was to display "Menu Migration" as a parent section within the Configuration area with the children "Export Types" and "Import Types" underneath. If I remember correctly, I couldn't easily achieve that within the Development section. So, I did something that's similar to the Devel generate module that has a second menu "Generate" under Configuration with the intention of skipping a click for the Import Types. Thoughts?


  • 🇩🇰Denmark ressa Copenhagen

    I think I prefer to just show it under /admin/config/development/menu-migration, on the same level as /admin/config/development/configuration, which is the most similar other menu entry, handling configuration export and import ...

    I created an MR which does this. What do you think?

  • 🇷🇴Romania bbu23

    Here's my conflict:
    1. I agree that there should be only one menu item within the Development section
    2. I dislike the fact that there will be a longer path of clicks to get to the desired pages

    Therefore at the moment I'll accept the changes, and see if there will be feedback on this in future versions. After all, there's the option of Shortcuts available to everybody. We'll see how it goes.
    Thank you!

    • bbu23 committed 7312038d on 4.0.x authored by ressa
      Issue #3486363: Menu Migration item present twice in the menu system
      
  • 🇷🇴Romania bbu23

    Adding a note that we might need to review README and Documentation for these changes in case it's needed.

  • 🇩🇰Denmark ressa Copenhagen

    Thanks for the flexibility and openness to try it out. As I see it:

    1. I rarely use the UI for navigation, mostly if I need to check if an update like this works. Otherwise, I always use Admin Toolbar :)
    2. The Configuration section is already quite crowded with 9 entries in my vanilla Drupal installation ... so keeping it in check is best, as I see it

    I forgot to update the configure key (the one that generates the links in the Extend section and after installing a module with Drush) in menu_migration.info.yml, sorry about that. Maybe you can do it manually, instead of me creating a new issue?

    From:
    configure: entity.mm_export_type.collection

    To:
    configure: menu_migration.menu_migration

    • bbu23 committed 14f7ce79 on 4.0.x
      Issue #3486363: Update the module configure route.
      
  • 🇷🇴Romania bbu23

    Valid points. I updated the key, thanks!

  • 🇩🇰Denmark ressa Copenhagen

    Perfect, thanks!

Production build 0.71.5 2024