Contrib.social

[PP-1] Tighten up TS definitions around LayoutNodes/RootNodes etc

Open on Drupal.org →
Created on 7 November 2024, 11 months ago

Overview

In the code review of 📌 Allow saving component compositions as sections Postponed @hooroomoo made a good observation that the TS definitions around LayoutNode, Node and RootNode are a bit loose. This issue proposes that we try to reduce that ambiguity to make the layoutUtils and layoutModelSlice reducers a bit tighter and easier to use.

Proposed resolution

Numerous utility functions can accept any Node with children but some specifically expect to have the RootNode passed in as they apply to the whole layout. These should be changed to explicitly expect a RootNode input and provide a RootNode output.

Marking as postponed as this MR builds on the changes implemented in 📌 Allow saving component compositions as sections Postponed and should be merged afterwards.

📌 Task
Status

Active

Version

0.0

Component

Page builder

Created by

🇬🇧United Kingdom jessebaker

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024