- Issue created by @jonathan1055
- 🇬🇧United Kingdom jonathan1055
Here is an example pipeline
https://git.drupalcode.org/project/scheduler/-/pipelines/328214Is the 'pages:deploy' job viewable by a user with higher authority than the project maintainer?
The documentation site is https://project.pages.drupalcode.org/scheduler but this is not shown in any job log or help page. Maybe we can at minimum add this to the pages log?
- 🇪🇸Spain fjgarlin
The only place where we can add some useful logs is here: https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes...
pages:deploy
is a GitLab specific job, so we have no control, but we can definitely add things to thepages
job. There is an CI variable with the URL to the generated site, so we can echo that. - 🇬🇧United Kingdom jonathan1055
Tested here
https://git.drupalcode.org/project/scheduler/-/pipelines/330500Is there anything else we can add?
- 🇮🇳India lavanyatalwar
@fjgarlin,
How about adding a line of dashes as a divider? - 🇪🇸Spain fjgarlin
That's almost exactly the comment that I made in the MR.
DIVIDER
is just a bunch of*
characters. - 🇪🇸Spain fjgarlin
Perfect. Look at other examples of how it is used within the file for reference.
- 🇮🇳India lavanyatalwar
@fjgarlin ,
Added the divider as desired.
Kindly check and merge :) - 🇮🇳India lavanyatalwar
@fjgarlin, done with the changes
Please have a look. - 🇮🇳India lavanyatalwar
@fjgarlin @jonathan1055,
Removed the extra '\n' character and '\' before $CI_PAGES_URL.
Kindly review :) - 🇬🇧United Kingdom jonathan1055
Thanks for fixing the message. Here is the test before
https://git.drupalcode.org/project/scheduler/-/jobs/3272612and after
https://git.drupalcode.org/project/scheduler/-/jobs/3279263All looks good now, but I will make an adjustment for that extra $divider variable in the 'check environment' job
- 🇬🇧United Kingdom jonathan1055
With this MR and $DIVIDER removed - 'environment check' before. The ended green because the pipe syntax was removed and the 'exit 1' was therefore not executed
https://git.drupalcode.org/project/scheduler/-/jobs/3279475With latest commit to this MR, 'environment check' has the correct message box and ends red as required.
https://git.drupalcode.org/project/scheduler/-/jobs/3280383I have resolved the various MR comment threads where the code has been fixed, and also reverted the temporoary change that allowed the 'pages' job to be tested.
Unrelated pipeline fail, due to 'check versions' showing that 11.0.6 and 10.3.7 have been released. This is RTBC from me, but will let @fjgarlin do the final review.
- 🇪🇸Spain fjgarlin
Oh wow, I didn't catch the
exit 1
being ignored, thanks for testing it!Did a final check, agree it's good to RTBC and merge.
- 🇪🇸Spain fjgarlin
Downstream with keycdn running pages: https://git.drupalcode.org/issue/gitlab_templates-3485285/-/pipelines/33...
-
fjgarlin →
committed 340ecd43 on main authored by
jonathan1055 →
Issue #3485285 by lavanyatalwar, jonathan1055, fjgarlin: Give better log...
-
fjgarlin →
committed 340ecd43 on main authored by
jonathan1055 →
Automatically closed - issue fixed for 2 weeks with no activity.