Link missing on SVGs with responsive image formatter

Created on 3 November 2024, 4 months ago

Problem/Motivation

While working on 📌 Formatters shouldn't repeat core code Needs review , I noticed a bug concerning the link feature in the SvgResponsiveImageFormatter. When I disable the setting, the formatter ignores the setting.

Steps to reproduce

Configure some view mode of an image media to use this module's responsive image formatter
Enable and set it to e.g. "Content"
Leave unchecked
View a page that references a media entity of the selected type, using an SVG image

Expected result: the image is linked to the content.
Actual result: the image is not linked.

If I enable the setting , the link appears.

Proposed resolution

Wrap the render array with a #link, just like SvgImageFormatter does.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

3.1

Component

Code

Created by

🇩🇪Germany mrshowerman Munich

Live updates comments and jobs are added and updated live.

Merge Requests

!42Link missing on SVGs with responsive image formatter
Merged
🇩🇪Germany mrshowerman
updated 4 months ago

Comments & Activities

Issue created by @mrshowerman
Merge request !42Fix linking of SVGs in responsive image formatter → (Merged) created by mrshowerman
Pipeline finished with Failed
4 months ago
Total: 469s
#328191
Pipeline finished with Failed
4 months ago
Total: 624s
#328193
Pipeline finished with Success
4 months ago
Total: 657s
#328192
Pipeline finished with Success
4 months ago
Total: 794s
#328194
Comment 4 months ago →
🇩🇪Germany mrshowerman Munich
Comment 4 months ago →
🇫🇷France mably
Thanks @mrshowerman for the find and the fix!
Comment 4 months ago →
🇫🇷France mably
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024