Contrib.social

Once failed but skipped checks shown as warning on status page

Open on Drupal.org →
Created on 2 November 2024, 3 months ago

Problem/Motivation

Checks which once failed but where later on marked as "Skipped" still result in warning on Drupal's status page ( "Security Review: There are failed Security Review checks").

Expected behavior (at least for me) would be to list "Security Review" under "Checked" as "Passing all non-ignored Security Review checks" - all non-ignored (not skipped) checks are OK.

Steps to reproduce

  • Run all checks with one check failing (e.g. "Some files and directories in your install are writable by the server")
  • Drupal's status page shows warning "Security Review: There are failed Security Review checks" (as expected)
  • Mark the failed checks as skipped
  • Re-run tests, Review results shows no fails (but skipped checks)
  • Drupal's status page stills shows warning "Security Review: There are failed Security Review checks"

I never encountered this before - so maybe I am doing something wrong?

Proposed resolution

Check if a failed check is skipped in security_review_requirements().

To me it looks like security_review_requirements() is not checking if a failed check is skipped - and a once failed failed test still is marked as CheckResult::FAIL.

Remaining tasks

Patch coming.

User interface changes

Correct status page.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇩🇪Germany gngn

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024