New durations overlay not next to date field

Created on 1 November 2024, about 2 months ago

The CSS for the durations overlay seems to be using position:absolute, which means that the overlay appears in a fixed location tied to the bottom of the page. If the page is really tall, the overlay won't be visible until you scroll down.

πŸ› Bug report
Status

Active

Version

4.2

Component

User interface

Created by

πŸ‡ΊπŸ‡ΈUnited States gribnif

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @gribnif
  • πŸ‡¨πŸ‡¦Canada mandclu

    What admin theme are you using?

  • πŸ‡¨πŸ‡¦Canada mandclu

    I have tested this in both Gin and Claro, and it works as expected. Unless I get detailed steps to reproduce on a fresh install or Drupal, I don't have a path forward.

  • πŸ‡ΊπŸ‡ΈUnited States gribnif

    1. Set up a test site using the evaluator guide: https://www.drupal.org/node/2997977 β†’
    2. Install smart_date: composer require 'drupal/smart_date:^4.2@beta'
    3. Create a new content type with a Smart Date Range.
    4. Change the form display mode to Smart Date|Classic and move the date field to the top of the page. These are the options I used, to match my original site:

    5. Add a new node using this content type. The default theme is Claro. This is what I see:

  • πŸ‡¨πŸ‡¦Canada mandclu

    Ah OK, so the issue is specific to the Classic widget. That shouldn't be an overly difficult fix.

    TBH I have been thinking of deprecating the Classic widget. Can I ask why you decided to use that one?

  • πŸ‡ΊπŸ‡ΈUnited States gribnif

    TBH I have been thinking of deprecating the Classic widget. Can I ask why you decided to use that one?

    I'm not entirely sure. I think it's simply because we've been using Smart Date since this was the only option. I just tried using Inline Range instead and, after some minor changes to the form_alter() hook we're using to set custom default values, I think it will work just fine--and it avoids the problem described above.

  • πŸ‡ΊπŸ‡ΈUnited States NicholasS

    We also ran into this bug, long time Smart Date users, and didn't even know new form display options existed. Seems like you could also fix the classic with a "position: relative" on the end date. We don't mind updating away from Classic, but probably lost of long term users of the module need notified to update their settings.

Production build 0.71.5 2024