[1.1.x] Convert ID string props to identifier props

$ grep -r -A 3 _id components/*/*.component.yml components/accordion/accordion.component.yml: accordion_id: components/accordion/accordion.component.yml- title: ID components/accordion/accordion.component.yml- description: 'Must start with a letter. Randomly generated if empty.' components/accordion/accordion.component.yml- type: string -- components/breadcrumb/breadcrumb.component.yml: breadcrumb_id: components/breadcrumb/breadcrumb.component.yml- title: ID components/breadcrumb/breadcrumb.component.yml- description: 'Must start with a letter. Randomly generated if empty.' components/breadcrumb/breadcrumb.component.yml- type: string -- components/button/button.component.yml: button_id: components/button/button.component.yml- title: ID components/button/button.component.yml- description: 'Used by the tooltip. Must start with a letter. Randomly generated if empty.' components/button/button.component.yml- type: string -- components/header/header.component.yml: header_id: components/header/header.component.yml- title: 'Header ID' components/header/header.component.yml- description: 'To generate unique id attributes if several headers are in the same page. Default is randomly generated.' components/header/header.component.yml- type: string -- components/link/link.component.yml: link_id: components/link/link.component.yml- title: 'Link ID' components/link/link.component.yml- description: 'Used by the tooltip. Must start with a letter. Randomly generated if empty.' components/link/link.component.yml- type: string -- components/modal/modal.component.yml: modal_id: components/modal/modal.component.yml- title: 'Modal ID' components/modal/modal.component.yml- description: "To link the triggered element (the one with 'aria-controls') and the modal." components/modal/modal.component.yml- type: string -- components/nav_menu/nav_menu.component.yml: html_id: components/nav_menu/nav_menu.component.yml- title: ID components/nav_menu/nav_menu.component.yml- description: 'Must start with a letter. Randomly generated if empty.' components/nav_menu/nav_menu.component.yml- type: string -- components/side_menu/side_menu.component.yml: html_id: components/side_menu/side_menu.component.yml- title: ID components/side_menu/side_menu.component.yml- description: 'Used for collapse mechanism. Must start with a letter. Randomly generated if empty.' components/side_menu/side_menu.component.yml- type: string components/side_menu/side_menu.component.yml: title_id: components/side_menu/side_menu.component.yml- title: 'Title ID' components/side_menu/side_menu.component.yml- description: 'An identifier for the side menu title. It must start with a letter and will be randomly generated if left empty.' components/side_menu/side_menu.component.yml- type: string -- components/summary/summary.component.yml: title_id: components/summary/summary.component.yml- title: 'Title ID' components/summary/summary.component.yml- description: 'Must start with a letter. Randomly generated if empty.' components/summary/summary.component.yml- type: string -- components/tab_panel/tab_panel.component.yml: unique_id: components/tab_panel/tab_panel.component.yml- title: 'Unique ID' components/tab_panel/tab_panel.component.yml- description: 'Must be unique in the scope of a Web page. The same ID will be passed to the corresponding tab.' components/tab_panel/tab_panel.component.yml- type: string -- components/tab/tab.component.yml: unique_id: components/tab/tab.component.yml- title: 'Unique ID' components/tab/tab.component.yml- description: 'Must be unique in the scope of a Web page. The same ID will be passed to the corresponding panel.' components/tab/tab.component.yml- type: string -- components/transcription/transcription.component.yml: transcription_id: components/transcription/transcription.component.yml- title: 'Transcription ID' components/transcription/transcription.component.yml- description: 'To generate unique id attributes if several transcriptions are in the same page. Default is randomly generated.' components/transcription/transcription.component.yml- type: string -- components/translate/translate.component.yml: translate_id: components/translate/translate.component.yml- title: ID components/translate/translate.component.yml- description: 'Used for collapse mechanism. Must start with a letter. Randomly generated if empty.' components/translate/translate.component.yml- type: string

Issue created by @pdureau
Comment 3 months ago →
🇫🇷France pdureau Paris
Comment 3 months ago →
🇫🇷France just_like_good_vibes PARIS
i take this one
Comment 2 months ago →
🇫🇷France pdureau Paris
Comment 2 months ago →
🇫🇷France pdureau Paris
May be a breaking changes because identifier is stricter than string.
Comment 2 months ago →
🇫🇷France pdureau Paris
Comment about 1 month ago →
🇫🇷France just_like_good_vibes PARIS
should we rename some props ?
Merge request !136Issue #3485082 by just_like_good_vibes, pdureau: ⚠️ Convert ID string props to identifier props → (Merged) created by just_like_good_vibes
Comment 28 days ago →
🇫🇷France just_like_good_vibes PARIS
Comment 28 days ago →
🇫🇷France pdureau Paris
i was a bit lost a t the beginning, because you didn't change all occurrences from templates, but only the initial snippet (example: {% set translate_id = id|default('translate-' ~ random()) %})

it looks OK to me

I have run sdc_devel, and no complains
Comment 27 days ago →
System Message

just_like_good_vibes → committed 86071836 on 1.1.x
Issue #3485082 by just_like_good_vibes, pdureau: ⚠️ Convert ID string...
Comment 27 days ago →
🇫🇷France just_like_good_vibes PARIS
Status changed to Fixed 13 days ago3:39pm 10 January 2025
Comment 13 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

[1.1.x] Convert ID string props to identifier props

Problem/Motivation

Proposed resolution

Merge Requests

!136[1.1.x] Convert ID string props to identifier props
Merged

Comments & Activities

[1.1.x] Convert ID string props to identifier props

Problem/Motivation

Proposed resolution

Merge Requests

!136[1.1.x] Convert ID string props to identifier propsMerged

Comments & Activities

!136[1.1.x] Convert ID string props to identifier props
Merged