- Issue created by @eiriksm
- π³π΄Norway eiriksm Norway
Hm there is quite a few failures but hard to imagine they are relevant to this MR
- πΊπΈUnited States phenaproxima Massachusetts
The tests have been aggressively failing due to problems with MySQL not starting - it's not our fault, but it's very annoying. The workaround is to keep rerunning the failed jobs (at least the ones that fail due to SQLState errors) until they pass.
This does, however, need an actual issue summary and better title, so kicking back for that.
- πΊπΈUnited States phenaproxima Massachusetts
No objections on my end, but would like @mglaman to sign off.
- πΊπΈUnited States mglaman WI, USA
Thanks for the version bump! This should be good to merge
@eiriksm did you manually test it locally or no? That's our one gap in coverage. The tests are Node only and we need to write the Cypress tests for this still.
Either way, I think fine to merge as the trial is having issues already. Maybe this fixed them!
-
phenaproxima β
committed 9ca39166 on 0.x authored by
eiriksm β
Issue #3484988 by eiriksm: Update trial dependencies for php-wasm...
-
phenaproxima β
committed 9ca39166 on 0.x authored by
eiriksm β
- πΊπΈUnited States phenaproxima Massachusetts
Thanks for signing off, @mglaman. Merrily merged into 0.x. Thanks!
- π³π΄Norway eiriksm Norway
>@eiriksm did you manually test it locally or no? That's our one gap in coverage. The tests are Node only and we need to write the Cypress tests for this still.
Hah, that would be the day.
I spent quite a while trying to get cypress to run this on a project. I found what I consider to be a bug, with a super easy to reproduce test case: https://github.com/cypress-io/cypress/issues/30405
I did not manually test it, no. I do however have a setup with my repo https://github.com/eiriksm/build-drupal-wasm which I am planning to get closer to what I consider "upstream" with drupal cms. The day only have so many hours :(
Anyway, the tests are pretty scarce but prove things are working for sure: https://github.com/eiriksm/build-drupal-wasm/blob/main/e2e/frontpage.spe...
Feel free to take stuff from there if someone has time
I should mention that I created this off of what I mentioned on the php-wasm discord. I have a CI system that does the bump for me basically, so we don't have to do this work manually and when we remember it
Automatically closed - issue fixed for 2 weeks with no activity.