- Issue created by @jurgenhaas
- π©πͺGermany jan kellermann
jan kellermann β made their first commit to this issueβs fork.
- π©πͺGermany jan kellermann
@jurgenhaas maybe checkout and test. This branch overrides hard the setup of klaro (we should add some config for this).
- All external media will be protected.
- All external sources are not loaded (because no consents given).
- I think the small privacy button should stay (can later be disabled, i added in an other ticket a description for creating menu item).Please have a look.
- π©πͺGermany jurgenhaas Gottmadingen
@jan kellermann that certainly goes in the right direction. Can we make that configurable in the klaro settings? It should, however, default to the current behaviour.
Would be great if that goes into the next RC. We could then run this by the Drupal CMS product owners.
- Merge request !30Resolve #3484938 "Add support for a less intrusive user experience mode" β (Merged) created by jan kellermann
- π©πͺGermany jan kellermann
I added config and an update-hook. Please have a look.
The new javascript is quite little tested - we need more than one review if possible (also with ajax and big pipe).
- π©πͺGermany rkoller NΓΌrnberg, Germany
I really like the direction this one takes. Moving the
Show Toggle Button
checkbox underneath the Klaro! Dialog Mode section feels semantically and functionally closer. I also like, by switching over to radio buttons, it makes the different kind of available dialog modes more prominent - pre-MR, those two checkboxes were highly confusing. And finally a few additional observations and thoughts:- When the MR is applied the radiobuttons are missing a default choice, none was selected for me? .
- Should the section, the
klaro dialog mode
radio button group and theshow toggle button
checkbox is in, also have section title likeservices
andbuttons
have? - In regards of the microcopy of the radio button labels. I would drop the verb "Show" which is redundant. About the naming of the "silent" option. Based on the info in the parenthesis and the help text underneath, i would assume that on my site no cookies or any external services are used and klaro remains unobtrusive - and as a naive none technical new user i would ask is klaro automatically testing that fact for me and otherwise the "silent" option wouldnt be available? And it is not clear if everything is blocked or if klaro stays just "silent" as the labels implies. i assume the former. i've also tried to test opening a node that contains a remote media item, there the klaro block and opt in functionality is active. so klaro is blocking the mandatory defaults and everything else requires an opt in? The radio button label "Silent" might trigger some misleading associations? In regards of the other three radio button labels, just based on their names, it is also not clear what the difference between a notice and a consent manager is function wise. Stylistically one of the options uses parenthesis, the other "as" and the other doesnt have anything related to modals. in case of the latter option it might make sense to use "none-modal" to illustrate the difference to the two modal options explicitly instead of implied?
- the online documentation and the menu link link point to the very same documentation page which only covers the part about menu links. i would rephrase the menu link documentation page. Instead of "can be used" i would use "has to be used". I would even move the detail, that this task requires the installation of the
link attributes
module, to the beginning of the page. Because i've just taken a look at the first one or two paragraphs and the screenshot and wondered where the attributes fieldset came from in the screenshot and how to get to being able to enter the rel attribute -> people only skim most of the time instead of thoroughly reading and my own example and experience is testament to that.
- π©πͺGermany jurgenhaas Gottmadingen
This is awesome. It can now be configured as if no consent management is available at all, and the site still remains compliant. Wonderful.
Can I suggest to add a link to the https://www.drupal.org/project/menu_link_attributes β module in the documentation as well? That would be required for users who want to create a menu link, and not a link field.
- π©πͺGermany jan kellermann
After merging the dev branch the install-file was broken.
I changed the settings form according to the discussion in #3485880.
I also changed the JS commands for silent mode. In my tests everything was fine.
Please review (hopefully for the last time).
- π©πͺGermany jurgenhaas Gottmadingen
This is still looking good. I haven't tested all scenarios, but silent and Notice dialog do work as expected.
Thank you so much, this is huge!
-
jan kellermann β
committed a9dd9ed3 on 3.x
Resolve #3484938 "Add support for a less intrusive user experience mode"
-
jan kellermann β
committed a9dd9ed3 on 3.x
Automatically closed - issue fixed for 2 weeks with no activity.