- Issue created by @pearls
- 🇦🇹Austria drunken monkey Vienna, Austria
drunken monkey → made their first commit to this issue’s fork.
- Merge request !184Resolve #3484686: Fix boosting by numeric field with negative value → (Merged) created by drunken monkey
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for reporting this issue!
I can immediately see the problem: While we always assume an item’s boost (or score) value is non-negative, there is nothing in the code actually ensuring this.
The fix is pretty simple for the “Number field-based boosting” – we even already have it there for date fields, we just didn’t think to also apply this for general numeric fields.
Created an MR for fixing this, please test/review!I also created 📌 Deprecate negative item scores/boosts Active as a follow-up to officially declare and verify that boosts cannot be negative.
Thanks @drunken monkey.
Please, confirm me if I need both MR(184-185).
Tested. I used both MR and it worked. It indexed without any warning/error.
+1 for RTBC- 🇦🇹Austria drunken monkey Vienna, Austria
Great to hear, thanks for testing!
Merged. -
drunken monkey →
committed ef98cf5c on 8.x-1.x
Issue #3484686 by drunken monkey: Fixed error when trying to boost on...
-
drunken monkey →
committed ef98cf5c on 8.x-1.x