- Issue created by @mh_nichts
- 🇫🇷France pdureau Paris
✨ Get rid of the mandatory "#" prefixes Active has added support to renderable without "#", but the old syntax is still available. It was not supposed to be a breaking change.
I don't see anything wrong in:
id: 'mypage' label: 'My page' render: - '#theme': layout__mytheme top_full: - '#type': pattern '#id': heading '#fields': title: 'Page title'
You have only "top_full" as
#theme': layout__mytheme
children? - 🇫🇷France mh_nichts
I posted a "reduced test case" but yes, the children of
'#theme': layout__mytheme
are only the regions names, and they aren't special keywords. - 🇫🇷France mh_nichts
I think maybe there is an exception to add when handling
content
which is a kind of special object ? - Merge request !20Issue #3484571 by mh_nichts, pdureau: Manage layouts regions → (Merged) created by pdureau
- 🇫🇷France pdureau Paris
Florent, do that mean our 1.0.0 implementation was too naive?
Let's discuss before merging.
(Note: UI Patterns 2 will also need this change)
- Assigned to Grimreaper
- Status changed to Needs work
about 2 months ago 7:05pm 27 January 2025 - 🇫🇷France Grimreaper France 🇫🇷
Need to wait for a fix in gitlab template to be deployed then I will be able to merge.
-
grimreaper →
committed 4c440880 on 1.x authored by
pdureau →
Issue #3484571 by grimreaper, pdureau, mh_nichts: Manage layouts regions
-
grimreaper →
committed 4c440880 on 1.x authored by
pdureau →
Automatically closed - issue fixed for 2 weeks with no activity.