Separate Tinycon into its own library and use favicon option to determine inclusion.

Created on 29 October 2024, 6 months ago

Problem/Motivation

We have a checkbox on the environment indicator settings form that give the illusion that you have a choice as to whether the tinycon javascript loads.

Steps to reproduce

Do not choose the favicon option.
Notice Tinycon library continues to load.

Proposed resolution

Separate Tinycon into its own library and use favicon option to determine inclusion.

Remaining tasks

Create a merge request to separate Tinycon library.

User interface changes

N/A

API changes

Selecting favicon option should include the library.

Data model changes

N/A

✨ Feature request
Status

Active

Version

4.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @trackleft2
  • Pipeline finished with Canceled
    6 months ago
    Total: 83s
    #324573
  • Pipeline finished with Success
    6 months ago
    Total: 143s
    #324574
  • Pipeline finished with Success
    6 months ago
    Total: 149s
    #324575
  • Pipeline finished with Success
    6 months ago
    Total: 138s
    #324584
  • πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ

    This merge request separates out the Tinycon and favicon functionality into separate libraries from the environment_indicator/drupal.environment_indicator library.

    Using the favicon option in environment_indicator.settings and the Drupal libraries and javascript APIs we can serve the Tinycon and favicon libraries.

  • Pipeline finished with Success
    6 months ago
    Total: 137s
    #324592
  • πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ
  • Pipeline finished with Success
    6 months ago
    #324605
  • Pipeline finished with Success
    6 months ago
    Total: 146s
    #324608
  • πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ
  • πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ
  • Pipeline finished with Success
    5 months ago
    Total: 139s
    #371886
  • πŸ‡ΊπŸ‡ΈUnited States trackleft2 Tucson, AZ πŸ‡ΊπŸ‡Έ

    trackleft2 β†’ changed the visibility of the branch 4.x to hidden.

  • Pipeline finished with Success
    3 months ago
    Total: 148s
    #430802
Production build 0.71.5 2024