- Issue created by @John Franklin
- c2d4042b committed on 8.x-1.x
Issue #3484416: Enable pipelines.
- c2d4042b committed on 8.x-1.x
- 5bb20a8a committed on 8.x-2.x
Issue #3484416: Enable pipelines.
- 5bb20a8a committed on 8.x-2.x
- 🇺🇸United States John Franklin
I just merged @nicholass's patch in 🐛 Error: Call to a member function load() on null BgImgFieldFormatter Active , which cleans up some of the phpcs findings. Make sure you're using the latest 8.x-2.x.
- Merge request !6Issue-bg_img_field-8.x-2.x: Fixed the phpcs, cspell, phpstan → (Open) created by arunsahijpal
- 🇮🇳India arunsahijpal
hi @john-franklin,
I've removed all the errors almost but there are some errors which are problematic, Please have a look.168 Parameter $token_service of method Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::__construct() has invalid type Drupal\token\TokenServiceInterface. 189 Access to an undefined property Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::$logger. https://phpstan.org/blog/solving-phpstan-access-to-undefined-property 396 Access to an undefined property Drupal\bg_img_field\Plugin\Field\FieldFormatter\BgImgFieldFormatter::$logger.
- 🇺🇸United States John Franklin
Shifting back to needs work to handle the merge conflict.
- Merge request !73484416-addressed-pipelines-issues: Fixed the issues. → (Merged) created by arunsahijpal
- 🇮🇳India arunsahijpal
arunsahijpal → changed the visibility of the branch 3484416-enable-gitlab-pipelines to hidden.
- 🇮🇳India arunsahijpal
Hi @john-franklin,
I have moved all the to new branch 3484416-addressed-pipelines-issues
and the new MR is : MR 7 -
john franklin →
committed c523d35c on 8.x-2.x authored by
arunsahijpal →
Issue #3484416 by arunsahijpal, john franklin: Enable gitlab pipelines...
-
john franklin →
committed c523d35c on 8.x-2.x authored by
arunsahijpal →
- 🇺🇸United States John Franklin
Merged with latest 8.x-2.x, cleaned up the residuals, merged. Thanks for the patch, @arunsahijpal!
Automatically closed - issue fixed for 2 weeks with no activity.