Contrib.social

Popper JS missing after #3471477

Open on Drupal.org →
Created on 29 October 2024, 5 months ago

Problem/Motivation

I think the change from #3471477 🐛 Fix Popper.js Error When Adding Navbar Dropdown in Varbase Components Fixed had side effects in that the popper library is missing and not replaced in certain parts.

One example is the dashboard page (admin/dashboard), there we get an error in the console:
Uncaught ReferenceError: Popper is not defined.

I think the reason is that admin/dashboard is _not_ and admin route, and because it's not declared as admin route the responsive preview toolbar item is displayed.
But due the library overwrite from #3471477 🐛 Fix Popper.js Error When Adding Navbar Dropdown in Varbase Components Fixed initialization fails.

Even worse, if JS preprocessing is enabled the JS error kills other JS code down the line e.g. toolbar-hover effects.
Right now the approach to permanently remove the library info of Responsive Preview seems not like the best idea.

Steps to reproduce

Proposed resolution

Replace the used popper library, do not just remove it.

Remaining tasks

  • ✅ File an issue about this project
  • ❌ Addition/Change/Update/Fix to this project
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Code review from 1 Varbase core team member
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇨🇭Switzerland das-peter

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024