- Issue created by @ressa
- 🇭🇺Hungary djg_tram
Sorry, it was an error and the system doesn't allow it to be revoked. I erroneously created a 2.0 tag after 1.9, without giving much thought, and only realized the error later. I deactivated it as much as the Drupal UI allows it but I can't completely remove it.
- 🇩🇰Denmark ressa Copenhagen
That's all right, no problem. I am grateful that you created and maintain the theme :)
But you cannot delete the tag? If not, maybe actually use it for Drupal 11 compatibility? Because it looks like it will pop up from now on, in Composer, causing confusion ...
If not, I think you could consider creating a Drupal core issue (infrastructure?) to solve it, since surely other project maintainers have or will run into this?
- 🇭🇺Hungary djg_tram
When I looked around, I found it discussed in some places that this is deliberate. GitLab, where the source code is hosted, doesn't allow a tag to be removed if it is still referenced, and you have no rights to remove the D.o reference as a mere developer. The D.o team could do it upon request but the old pointers to where we could ask for it are no longer valid.
- 🇩🇰Denmark ressa Copenhagen
I see, thanks for clarifying. It will pop up in Composer's
outdated
command forever then:$ composer outdated "drupal/*" Direct dependencies required in composer.json: drupal/claro_compact 1.10.0 2.0.0 A compact version of Claro (Drupal administration theme). Fully compatible with Claro, just with the overall spacing reduced. drupal/core-composer-scaffold 10.3.6 11.0.5 A flexible Composer project scaffold builder. drupal/core-project-message 10.3.6 11.0.5 Adds a message after Composer installation. drupal/core-recommended 10.3.6 11.0.5 Core and its dependencies with known-compatible minor versions. Require this project INSTEAD OF drupal/core.
I think using version 2 for Drupal 11 would make sense, if only to get this cleaned up, once and for all.
- 🇩🇰Denmark ressa Copenhagen
Actually, shouldn't we make Claro compact Drupal 11 compatible under all circumstances?
- 🇭🇺Hungary djg_tram
I'd give it almost zero chance of not being compatible with 11 as is but could someone with an actual 11 check it out, merely by adding ^11 to the info.yml?
- 🇩🇰Denmark ressa Copenhagen
I installed Claro compact in Drupal 11.0.5, clicked around on Views, config pages, the node edit page, etc., and everything looks fine.
I am attaching a diff between Drupal 10.3.6 and 11.0.5, only containing changes under /core/themes/claro/css made with
git diff 10.3.6 11.0.5
. - 🇩🇰Denmark ressa Copenhagen
Thanks. Right now, 8.x-1.x is the default branch ... Maybe create a version 8.x-2.x on Gitlab like this, and set as default?:
https://git.drupalcode.org/project/claro_compact/-/tree/8.x-2.x - 🇭🇺Hungary djg_tram
Do you think this is important? The tag is 2.x and I got the upgrade in my website all right, so it seems just fine to me as is. Is it really important to keep the branch name in sync?
- 🇩🇰Denmark ressa Copenhagen
Yes, I do believe. It's best practice to have a dev-version to commit changes to. See these modules, all with a dev-version for development, like most well maintained modules and themes have:
- https://www.drupal.org/project/token →
- https://www.drupal.org/project/pathauto →
- https://www.drupal.org/project/metatag →
- https://www.drupal.org/project/webform →
- https://www.drupal.org/project/admin_toolbar →
- https://www.drupal.org/project/field_group →
- https://www.drupal.org/project/entity →
- https://www.drupal.org/project/redirect →
- 🇭🇺Hungary djg_tram
Sure, with code modules where things can go wrong. But with a theme?
OK, I'll look into it, my main problem is that I use GitHub almost daily for Flutter development and know it quite well while with the Drupal system, including their only half-baked solution with GitLab and the old, tedious manual publishing of new versions, I always need to consult my notes to remember how it worked the last time around. :-)
- 🇩🇰Denmark ressa Copenhagen
Thanks, much better :)
And perhaps, as the final step, add it to the project page, and get it listed at the bottom? Then it gets a link to a dedicated page, with for example the Composer download and other interesting data. I.e. this kind of page, but for 8.x-2.x-dev: https://www.drupal.org/project/claro_compact/releases/8.x-2.1 →
See: https://www.drupal.org/docs/develop/git/git-for-drupal-project-maintaine... →
- 🇩🇰Denmark ressa Copenhagen
Oh, and feel free to check both user checkboxes under "Credit & committing" since we have both contributed, and made it Drupal 11 ready.
See https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... →
- 🇭🇺Hungary djg_tram
I seem to remember that D.o promised to make this contribution setting automatic some time ago, sad to see it's still not working...
- 🇩🇰Denmark ressa Copenhagen
No, it was changed to no automatic crediting at all, due to users gaming the system. You as a maintainer need to actively enable credit for those who should get credited under "Credit & committing". The issue creator, patch creators, etc. are no longer automatically credited ... see 📌 Remove issue credit suggestions Fixed and #3226881: Do not automatically credit people who upload files to an issue → .
When the issues move to Gitlab, the automatic crediting will become more streamlined, see https://www.drupal.org/project/simplenews/issues/3395901#comment-15635974 📌 Use gitlab-ci Needs work
The page documentation page https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... → -- about who should be credited and how, was ambiguously worded, so I have recently updated it, to hopefully make it clearer.
PS. About adding dev-release to project page (as I asked in #15) is it possible?
- 🇩🇰Denmark ressa Copenhagen
Thanks for adding the dev-version to the project page.
- 🇭🇺Hungary djg_tram
You're welcome. Although I wouldn't call that linked documentation very clear, it's still much easier than the USB quagmire I'm currently in in another project. Not related, anyway. ;-))
Automatically closed - issue fixed for 2 weeks with no activity.