Add support for attributes

Created on 27 October 2024, 5 months ago

Problem/Motivation

Let's add support for attributes.

📌 Task
Status

Active

Version

3.0

Component

Code

Created by

🇯🇵Japan ptmkenny

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Pipeline finished with Success
    6 months ago
    Total: 223s
    #310620
  • Pipeline finished with Success
    6 months ago
    Total: 210s
    #310646
  • Pipeline finished with Success
    6 months ago
    Total: 417s
    #319676
  • Issue created by @ptmkenny
  • Merge request !61add attribute → (Merged) created by ptmkenny
  • 🇯🇵Japan ptmkenny

    I ported the annotation, but I removed "class" because attributes already have that.

  • Pipeline finished with Success
    5 months ago
    Total: 256s
    #322164
  • Pipeline finished with Failed
    5 months ago
    Total: 232s
    #322165
  • Pipeline finished with Failed
    5 months ago
    Total: 229s
    #322169
  • Pipeline finished with Failed
    5 months ago
    Total: 247s
    #326681
  • Pipeline finished with Failed
    5 months ago
    Total: 767s
    #332725
  • Pipeline finished with Skipped
    5 months ago
    #339592
  • Pipeline finished with Success
    5 months ago
    #346622
  • 🇯🇵Japan ptmkenny

    Forgot to wire up the attribute; that's fixed now and I think this is ready to go.

  • Pipeline finished with Failed
    5 months ago
    Total: 286s
    #346788
  • Pipeline finished with Success
    5 months ago
    Total: 826s
    #346787
  • Pipeline finished with Failed
    5 months ago
    Total: 390s
    #348534
  • Pipeline finished with Success
    5 months ago
    #348539
  • Pipeline finished with Failed
    4 months ago
    Total: 296s
    #349450
  • Pipeline finished with Failed
    4 months ago
    Total: 306s
    #349451
  • Pipeline finished with Success
    4 months ago
    Total: 173s
    #357411
  • Pipeline finished with Success
    4 months ago
    Total: 170s
    #357420
  • Pipeline finished with Success
    4 months ago
    Total: 172s
    #357431
  • Pipeline finished with Success
    4 months ago
    Total: 167s
    #357518
  • Pipeline finished with Success
    4 months ago
    Total: 189s
    #357539
  • Pipeline finished with Success
    4 months ago
    Total: 260s
    #357547
  • 🇳🇱Netherlands bbrala Netherlands

    Thanks for this.

    I wonder if we should to the BC way, supporting both annotaatinos and attributes. But perhaps since we are the source of the manager only supporting getting things by annotations is fine. Do you agree?

  • 🇯🇵Japan ptmkenny

    The annotation class is still there, so annotations are still supported for people who have written their own plugins on top of JSON:API Extras and are using annotations.

    As for the plugins in this module, it is fine to convert them to attributes now because the module's composer.json already has "php": ">=8.1", so attributes will definitely be supported (attribute support is from 8.1). So I don't think this should break anything for anyone.

  • Pipeline finished with Skipped
    4 months ago
    #361745
  • Pipeline finished with Skipped
    4 months ago
    #361746
  • 🇳🇱Netherlands bbrala Netherlands

    Yeah same cocnclusion here. Thanks!

  • Pipeline finished with Success
    4 months ago
    Total: 266s
    #366389
  • Pipeline finished with Success
    4 months ago
    Total: 196s
    #366398
  • Pipeline finished with Success
    4 months ago
    Total: 135s
    #371811
  • Pipeline finished with Success
    4 months ago
    Total: 139s
    #371813
  • Pipeline finished with Success
    4 months ago
    Total: 133s
    #371815
  • Pipeline finished with Success
    4 months ago
    Total: 144s
    #372968
  • Pipeline finished with Success
    4 months ago
    Total: 145s
    #373752
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    3 months ago
    Total: 320s
    #378428
  • Pipeline finished with Failed
    3 months ago
    Total: 618s
    #400115
  • Pipeline finished with Success
    2 months ago
    Total: 149s
    #409267
  • Pipeline finished with Skipped
    2 months ago
    #415186
  • Pipeline finished with Failed
    about 2 months ago
    Total: 165s
    #421417
  • Pipeline finished with Success
    about 2 months ago
    Total: 140s
    #424060
  • Pipeline finished with Success
    about 2 months ago
    Total: 274s
    #424088
  • Pipeline finished with Success
    about 2 months ago
    Total: 253s
    #424377
  • Pipeline finished with Skipped
    about 1 month ago
    #441657
  • Pipeline finished with Success
    29 days ago
    Total: 219s
    #445475
  • Pipeline finished with Failed
    29 days ago
    Total: 216s
    #445902
  • Pipeline finished with Failed
    29 days ago
    Total: 154s
    #445921
  • Pipeline finished with Failed
    29 days ago
    Total: 200s
    #445931
  • Pipeline finished with Success
    29 days ago
    Total: 332s
    #445955
  • Pipeline finished with Success
    28 days ago
    Total: 395s
    #445971
  • Pipeline finished with Success
    28 days ago
    Total: 214s
    #445983
  • Pipeline finished with Success
    27 days ago
    Total: 229s
    #446984
  • Pipeline finished with Success
    2 days ago
    #467344
Production build 0.71.5 2024