Incompatibility with proposed core patch to allow excluding blocked users

Created on 24 October 2024, 23 days ago

Problem/Motivation

FYI, I just tested patch #39 ✨ Add filter option to UserSelection to exclude blocked users Closed: outdated in this core issue ( ✨ Add filter option to UserSelection to exclude blocked users Closed: outdated ) and suggested to include it in core (with minor modifications), but I later noticed that it broke this module in case a user would use the new (if accepted) core option to disable blocked users selections, and a user with the permission added by this module was about to edit the form.

You might want to adjust this module behaviour or the suggested patch to cover the core's feature request, to make the two work together 😇

Thank you

✨ Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇮🇹Italy kopeboy Milan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @kopeboy
  • 🇮🇹Italy kopeboy Milan
  • 🇮🇹Italy kopeboy Milan

    When visiting the entity form with the user reference field, with the new core option that excludes blocked users, I got these:

    2 Warnings:

    Undefined array key "dependent_fields_view" in dependent_fields_field_widget_single_element_form_alter() (line 58 of /var/www/html/web/modules/contrib/dependent_fields/dependent_fields.module)

    Message Warning: Trying to access array offset on null in Drupal\dependent_fields\Plugin\EntityReferenceSelection\ViewsSelection->getReferenceableEntities() (line 523 of /var/www/html/web/modules/contrib/dependent_fields/src/Plugin/EntityReferenceSelection/ViewsSelection.php)

    1 fatal error:
    TypeError: Symfony\Component\HttpFoundation\Request::get(): Argument #1 ($key) must be of type string, null given, called in /var/www/html/web/modules/contrib/dependent_fields/src/Plugin/EntityReferenceSelection/ViewsSelection.php on line 647 in Symfony\Component\HttpFoundation\Request->get() (line 700 of /var/www/html/vendor/symfony/http-foundation/Request.php).

    When

  • 🇺🇸United States flashwebcenter Austin TX

    Hello,

    I understand that work is underway on this feature in Drupal core, and I’ve mentioned that on the homepage for this module. However, I’m still uncertain if the patch will address the Authored By field, which was the primary motivation for creating this module. In any case, I’ll wait until this feature is fully integrated into Drupal core.

    I'm not a big fan of patching core; if the choice is between patching core and installing a contrib module, I always opt for the contrib.

    Thank you!
    Alaa

Production build 0.71.5 2024