- Issue created by @AlfTheCat
-
marcus_johansson →
committed a5d28cd0 on 3483197-text-format-is
Issue #3483197: Text format is escaped until (manual) re-save
-
marcus_johansson →
committed a5d28cd0 on 3483197-text-format-is
- 🇩🇪Germany marcus_johansson
Thanks for reporting. Confirmed bug on the combination Formatted Text and LLM: Text (simple). A fix is being merged now.
-
marcus_johansson →
committed 827d7384 on 1.0.x
Issue #3483197: Text format is escaped until (manual) re-save
-
marcus_johansson →
committed 827d7384 on 1.0.x
- 🇹🇭Thailand AlfTheCat
Hi Marcus,
Thanks for the quick work, I'm on the latest dev and I'm still experiencing the issue.
- 🇩🇪Germany marcus_johansson
Could you send the following over:
* Field type
* Configuration of Input field type, specifically which formats you chosen. - 🇹🇭Thailand AlfTheCat
Hi Marcus,
The field is on taxonomy terms, of the type: Text (formatted, long, with summary).
Attached is the field config and the automator config.Nothing special is configured regarding input formats, it defaults to "basic HTML". After manual save the text is properly formatted.
Thanks!
-
marcus_johansson →
committed 55bb1068 on 3483197-text-format-is
Issue #3483197 by alfthecat, marcus_johansson: Text format is escaped...
-
marcus_johansson →
committed 55bb1068 on 3483197-text-format-is
-
marcus_johansson →
committed 04f77f4d on 3483197-text-format-is
Issue #3483197 by alfthecat, marcus_johansson: Text format is escaped...
-
marcus_johansson →
committed 04f77f4d on 3483197-text-format-is
-
marcus_johansson →
committed 1a10add3 on 3483197-text-format-is
Issue #3483197 by alfthecat, marcus_johansson: Text format is escaped...
-
marcus_johansson →
committed 1a10add3 on 3483197-text-format-is
-
marcus_johansson →
committed f39da367 on 3483197-text-format-is
Issue #3483197 by alfthecat, marcus_johansson: Text format is escaped...
-
marcus_johansson →
committed f39da367 on 3483197-text-format-is
- 🇩🇪Germany marcus_johansson
Thank you and thank you for the bug find, this turned out to be an really valueble bug that lead to some security fixing and a new feature. I usually run OpenAI with complex outputs everywhere and the simple output is just what something I added because I know people want to run Ollama, so:
1. The Text with Summary was missing the formatting (bug).
2. However the other issue is that when you do not choose any text formatters on field config, you should have access to all. The code was that you got nothing (bug).
3. Even if you have access to all or some, you should only actually be able to get the ones your user role has access to (security bug).
4. The problem with smaller models is that they might answer - "Yes, here is some HTML about the topic ```html some text... ```". We need to be able to extract it (feature).All this is fixed now, the feature is based on the output from OpenAI and Llama and doesn't have automated testing yet, but I assume there will be more bug reports as people try it on other modules ;)
The feature adds a dropdown.
You can test it on dev now and hopefully it finally works
-
marcus_johansson →
committed b0fa9a0b on 1.0.x
Resolve #3483197 "Text format is"
-
marcus_johansson →
committed b0fa9a0b on 1.0.x
-
marcus_johansson →
committed b0fa9a0b on 3482073-create-imageareaofinterest-operation
Resolve #3483197 "Text format is"
-
marcus_johansson →
committed b0fa9a0b on 3482073-create-imageareaofinterest-operation
-
marcus_johansson →
committed 827d7384 on 3482073-create-imageareaofinterest-operation
Issue #3483197: Text format is escaped until (manual) re-save
-
marcus_johansson →
committed 827d7384 on 3482073-create-imageareaofinterest-operation
- 🇹🇭Thailand AlfTheCat
Hi Marcus, awesome, thanks very much for the fix. I'm testing it now.
- 🇹🇭Thailand AlfTheCat
Hi guys, I just ran into an issue where if the automator runs via cron, this issue still persists.
- 🇩🇪Germany marcus_johansson
Verified - this makes sense with how its built - currently is checking your access for text formats and saves based on what is availabe to your user. But the cron job runs as anonymous, which means no access to any filters format.
I have instead now added a drop down where you can set the filter format it should be save as - if the admin sets something here that the user doesn't have access to they will still be able to create it with this - so it should be used sparsly, but when you need cronjob this (or adding sessions to cronjobs) is the only way to solve it. I think.
Its getting merged, select from the dropdown and see if it works better.
-
marcus_johansson →
committed 35ce8a83 on 1.0.x
Issue #3483197 by alfthecat, marcus_johansson: Text format is escaped...
-
marcus_johansson →
committed 35ce8a83 on 1.0.x
-
marcus_johansson →
committed cd8c567c on 1.0.x
Issue #3483197 by alfthecat, marcus_johansson: Text format is escaped...
-
marcus_johansson →
committed cd8c567c on 1.0.x
-
marcus_johansson →
committed 96b1c5a7 on 1.0.x
Issue #3483197 by alfthecat, marcus_johansson: Text format is escaped...
-
marcus_johansson →
committed 96b1c5a7 on 1.0.x
- 🇹🇭Thailand AlfTheCat
Hi Marcus, thanks for the fix. This is a great setting to have.