- Issue created by @mstrelan
- Merge request !9928Issue #3483050: Add int return type to all hook_update_last_removed implementations → (Closed) created by mstrelan
- 🇳🇱Netherlands bbrala Netherlands
Another lveoly clearnup. Starting to repeat myself, but changes look good. When lookin in code, this is exactly what should have been changes. See no missed code. Count didnt add up initially, but that is because of the string in "update_test_last_removed.into.yml".
- 🇳🇿New Zealand quietone
I too applied the diff and searched. I found all instances fixed but this needs to be rebased.
- 🇦🇺Australia mstrelan
Postponing on 📌 Add array return type to all hook_removed_post_updates implementations Active as it doesn't make sense to rebase each of these, let's do one at a time.
- 🇮🇳India akulsaxena
The issue seems to be worked on correctly and
: int
was added to all the required instances. The target branch is 56 commits behind the source branch and thus needs to be rebased. - 🇮🇳India akulsaxena
Hi @mstrelan
The pipeline you ran after rebasing is failing the PHPUnit (Functional) test.
Please take a look. - 🇦🇺Australia mstrelan
Thanks, but these were known random failures, unrelated to this issue. I've retried the pipeline and it passed.
- 🇮🇳India akulsaxena
@mstrelan
Didn't know that those were known random failures. I thought some PHPUnit tests were failing!
The Changes look good, int return type was added to all hook_update_last_removed implementations.
Also, The pipeline is all green now!
Moving it to RTBC. - 🇺🇸United States nicxvan
I did 📌 Add void return type to all hook_form_alter, hook_form_FORM_ID_alter and hook_form_BASE_FORM_ID_alter implementations Active first , might as well wait until that gets in before doing this one.
- 🇮🇳India akulsaxena
@nicxvan
The tasks in the issue seem completed. Great work.
Rebase looks fine, and all tests are green.
Moving it to RTBC. - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.1.x thanks!
- 🇮🇳India akulsaxena
Hi @catch,
I have been actively following and testing the issue to confirm its resolution. Once I verified that the issue was resolved, I also moved it to the "Reviewed and Tested by Community" state.
As I contributed to this process, I would appreciate it if my effort could be acknowledged with credit. This recognition would be highly motivating and encourage me to continue contributing.
Thank you for your attention to this matter. I look forward to your response.
Best regards,
Akul - 🇬🇧United Kingdom catch
@akulsaxena there's not enough in this issue for an RTBC to count towards issue credit, see https://www.drupal.org/about/core/policies/maintainers/how-is-credit-gra... →
Automatically closed - issue fixed for 2 weeks with no activity.