Access modifiers should not be private for attributes and method

Created on 23 October 2024, 29 days ago

Problem/Motivation

I am attempting to create a derived class from the VertexAISearch plugin class.
Currently, I am unable to do this because some of the attributes are 'private' rather than 'protected'.

Steps to reproduce

Look at the code.

private $searchPageRepository;
private $tokenManager;
private $moduleExtensionList;
private function performSearch(SearchServiceClient $searchServiceClient, SearchRequest $request) {

Proposed resolution

Change the access modifiers for the above properties and methods to 'protected'.

🐛 Bug report

Status

Active

Version

1.2

Component

Code

Created by

🇺🇸United States tzura

Live updates comments and jobs are added and updated live.

integration

Comments & Activities

Issue created by @tzura
@timozura opened merge request.

Comment 28 days ago →

System Message

timozura → committed c7c7d4a0 on 1.0.x

Issue #3483007 by timozura: Access modifiers should not be private for...

Comment 28 days ago →
🇺🇸United States tzura
Comment 14 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024