Anyone who knows a submission's uuid can confirm that submission

Created on 23 October 2024, 7 months ago

Problem/Motivation

This module has a potential security issue. The submission confirmation endpoint only takes a submission UUID, which means that anyone who knows that UUID can confirm the submission. The UUID is not very secret information, in certain setups it might be exposed when creating the submission.

Proposed resolution

Create confirmation urls that contain the submission UUID, the submission created timestamp and a hash of both previous values combined, hashed using the site hash salt as secret key. This is similar to the way password reset links are constructed in Drupal. As an added benefit, we can add an option to the webform handler to make confirmation links expire, without much additional effort.

User interface changes

For end users, none. For webform editors, a new 'Expire after' option in the handler settings.

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇧🇪Belgium dieterholvoet Brussels

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024