WSOD when creating a User reference field

I got this too..
The user entity reference field would work for my up until I installed the commerce_order module.
Something to do with the Plugin\EntityReferenceSelection\UserSelection in the commerce_order module I suppose..

As soon as we set the group to "default", indeed the bug is fixed, but you cannot select our custom selection handler from the UI... due to the following code:

 $selection_group_plugin = $selection_group_id . ':' . $this->getSetting('target_type');
$handlers_options[$selection_group_plugin] = Html::escape($selection_plugins[$selection_group_id][$selection_group_plugin]['base_plugin_label']);

On D10 you can select it, but it looks buggy as the option offered in the UI has no label... Should we just not allow the selection from the UI? Alternative would be to set the base_plugin_label from an alter hook but this is an hackish approach... Thoughts?

The fix from the MR gives us the ability to choose our selection handler from the UI while retaining the existing ID which means if the selection handler is used by an existing field or custom code, it won't break... So tempted to just go with the workaround...
@zaporylie, @2pha: thoughts?

Considering the fix from the MR fixes the issue reported, I went ahead and merged the MR... The fix is doesn't break potential code relying on the plugin ID which doesn't change with the fix merged...

@jsacksick thanks.

Automatically closed - issue fixed for 2 weeks with no activity.