- Issue created by @mortona2k
- 🇺🇸United States mortona2k Seattle
I can't create a merge request for some reason.
The dependency wasn't enough. I prefixed the button selector with the selector used in the navigation library, which was colliding.
The navigation library uses [class*="toolbar-button--icon"].
- First commit to issue fork.
- 🇮🇪Ireland lostcarpark
lostcarpark → changed the visibility of the branch 1.0.x to hidden.
- 🇮🇪Ireland lostcarpark
Thanks for reporting this issue.
I wonder is it possible you were testing with Beta1 or 2? These were inadvertently loading the contrib version of the Navigation module, which was overriding the icon defined in the CSS. This didn't happen for me with Beta3, which is correctly using the core version of Navigation.
Nevertheless, I think a more specific selector is a good thing, and I'm happy to merge this fix.
I think the reason you couldn't create a merge request is you had checked your change into the 1.0.x branch, rather than creating a new branch. I have pulled your change into a new branch and created a merge request off that.
- 🇺🇸United States mortona2k Seattle
Oh you're right, I had the contrib version of navigation installed. Looks like this is not really an issue, but it will at least correct it for other people with the same situation until they upgrade.
- 🇮🇪Ireland lostcarpark
That's okay, good to confirm that's the reason.
Hopefully not too many people are affected. I'll probably roll this into beta4 tomorrow.
Automatically closed - issue fixed for 2 weeks with no activity.