Contrib.social

Pass feed configuration to HttpFetcher::get()

Open on Drupal.org →
Created on 21 October 2024, 6 months ago

Problem/Motivation

HttpFetcher::get() does not pass feed configuration. This would reduce the need to overwrite the HttpFetcher::fetch() function

Steps to reproduce

Proposed resolution

Add parameter to get function
protected function get($url, $sink, $cache_key = FALSE, array $options = [], $feed_configuration = [] )

Add parameter to get function call
$response = $this->get($feed->getSource(), $sink, $cache_key, $feed->getConfigurationFor($this->plugin));

Remaining tasks

User interface changes

API changes

from:
protected function get($url, $sink, $cache_key = FALSE, array $options = [])

to:
protected function get($url, $sink, $cache_key = FALSE, array $options = [], $feed_configuration = [] )

Data model changes

✨ Feature request
Status

Active

Version

3.0

Component

Code

Created by

🇩🇪Germany sleitner

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024