- Issue created by @elc
- 🇦🇺Australia elc
Still failing with concurrent turned off. Test does show as passed, but it has the same error messages. No more useful an error message.
Drupal: 11.0-dev PHP 8.3.12 (cli) (built: Oct 8 2024 18:47:22) (NTS) Copyright (c) The PHP Group [snip] PHPUnit 10.5.37 by Sebastian Bergmann and contributors. Notice: file_get_contents(): Read of 8352 bytes failed with errno=21 Is a directory in /builds/issue/genpass-3482165/web/core/lib/Drupal/Component/Annotation/Doctrine/StaticReflectionParser.php on line 184
- 🇦🇺Australia elc
Possibly related to the addition of Hook Attributes:
📌 OOP hooks using event dispatcher Needs reviewAnd
Change notice: Support for object oriented hook implementations using autowired services →Backwards-compatible Hook implementation for Drupal versions from 10.1 to 11.0
Contrib modules which want to adopt this new approach to hooks and continue to support Drupal 10.1 and 11.0 are recommended to implement a new hook class, manually register that class as a service, and add a shim procedural implementation
Documentation and examples are not immediately available.
- 🇦🇺Australia elc
Core modules are being converted.
📌 Test issue please ignore: Rector on user ActiveAttempted adding GenpassHooks to see if it would get rid of the error, which did not work.
Not sure if this is really hook related, but the new OOP hook methodology need to be adopted.
- 🇦🇺Australia elc
Core fix required - this is in an unreleased core:
🐛 Symlinking a module breaks HookCollectorPass ActiveLocal issue demonstrating tests working with a patched core:
🐛 Run tests against a patched core 3482283 ActiveI wasn't going to figure this one out in a hurry, thank you.
How on earth did you find this module's issue?
Postponed pending 3482283, at which time this will be closed (outdated).
- 🇺🇸United States nicxvan
You can thank @chi for that!
https://www.drupal.org/project/drupal/issues/3442009#comment-15824270 📌 OOP hooks using event dispatcher Needs review
- 🇦🇺Australia elc
Change has been committed to 11-dev and the next major job is working on the testing pipeline.
https://git.drupalcode.org/issue/genpass-3482165/-/jobs/3122350
Automatically closed - issue fixed for 2 weeks with no activity.