Refactor getApiKey from SendgridHandler::sendMail

Created on 18 October 2024, about 2 months ago

Problem/Motivation

SendgridHandler::sendMail is 100 lines method. I'd need to use different sendgrid keys based on different contexts, so I need to provide my own sendgrid.mail_handler service and copypaste lots of code.
Would be great if there was a getApiKey() method, so I could only implement that one.

Proposed resolution

Create a getApiKey() method to extract that from sendMail.
Won't add it to the interface, as that would require a new major version because of the API addition.

Remaining tasks

MR.

User interface changes

None.

API changes

None (the method can be protected).

Data model changes

None.

✨ Feature request

Status

Active

Version

1.0

Component

Code

Created by

🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺

Live updates comments and jobs are added and updated live.

Merge Requests

!3Refactor getApiKey from SendgridHandler::sendMail
Merged
🇪🇸Spain penyaskito
updated about 1 month ago

Comments & Activities

Issue created by @penyaskito
Merge request !3Issue #3481802: Refactor getApiKey from SendgridHandler::sendMail → (Merged) created by penyaskito
Comment about 2 months ago →
🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Comment about 1 month ago →
System Message

penyaskito → committed e20fe096 on 1.0.x
Issue #3481802: Refactor getApiKey from SendgridHandler::sendMail
Comment about 1 month ago →
🇪🇸Spain pcambra Asturies
Don't see why not :) thanks!
Comment 28 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024